[llvm-bugs] [Bug 37484] New: src/experimental/filesystem/directory_iterator.cpp:98: suspicious call to strcmp

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=37484

            Bug ID: 37484
           Summary: src/experimental/filesystem/directory_iterator.cpp:98:
                    suspicious call to strcmp
           Product: libc++
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P
         Component: All Bugs
          Assignee: unassignedclangbugs at nondot.org
          Reporter: dcb314 at hotmail.com
                CC: llvm-bugs at lists.llvm.org, mclow.lists at gmail.com

libcxx/src/experimental/filesystem/directory_iterator.cpp:98]: (warning) The
expression 'strcmp(__data_.cFileName,"..") != 0' is suspicious. It overlaps
'!strcmp(__data_.cFileName,".")'.

Source code is

  if (!strcmp(__data_.cFileName, ".") || strcmp(__data_.cFileName, ".."))
        continue;

Maybe better code

  if (strcmp(__data_.cFileName, ".") == 0 || strcmp(__data_.cFileName, "..") ==
0)
        continue;

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20180516/5cdf04fe/attachment.html>