[llvm-bugs] [Bug 37666] New: llvm/utils/TableGen/FastISelEmitter.cpp: 4 * avoid passing structs by value ?

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=37666

            Bug ID: 37666
           Summary: llvm/utils/TableGen/FastISelEmitter.cpp: 4 * avoid
                    passing structs by value ?
           Product: new-bugs
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: dcb314 at hotmail.com
                CC: llvm-bugs at lists.llvm.org

[trunk/llvm/utils/TableGen/FastISelEmitter.cpp:42]: (performance) Function
parameter 'Name' should be passed by const reference.
[trunk/llvm/utils/TableGen/FastISelEmitter.cpp:43]: (performance) Function
parameter 'PhysRegs' should be passed by const reference.
[trunk/llvm/utils/TableGen/FastISelEmitter.cpp:44]: (performance) Function
parameter 'PredicateCheck' should be passed by const reference.
[trunk/llvm/utils/TableGen/FastISelEmitter.cpp:43]: (performance) Function
parameter 'SubRegNo' should be passed by const reference.

Source code is

 InstructionMemo(std::string Name, const CodeGenRegisterClass *RC,
                  std::string SubRegNo, std::vector<std::string> PhysRegs,
                  std::string PredicateCheck)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20180603/c8fd0f3f/attachment.html>