[llvm-bugs] [Bug 36004] New: clang-format preprocessor indentation instability and trailing directive's off by one

via llvm-bugs llvm-bugs at lists.llvm.org
Thu Jan 18 07:21:59 PST 2018


https://bugs.llvm.org/show_bug.cgi?id=36004

            Bug ID: 36004
           Summary: clang-format preprocessor indentation instability and
                    trailing directive's off by one
           Product: clang
           Version: 6.0
          Hardware: All
                OS: All
            Status: NEW
          Severity: release blocker
          Priority: P
         Component: Formatter
          Assignee: unassignedclangbugs at nondot.org
          Reporter: mzeren at vmware.com
                CC: djasper at google.com, klimek at google.com,
                    krasimir at google.com, llvm-bugs at lists.llvm.org
            Blocks: 35804

r312125, which introduced preprocessor indentation, shipped with a known
issue where "indentation of comments immediately before indented
preprocessor lines is toggled on each run". There's a second issue where
trailing directives may be indented incorrectly. Both issues have reviews out:
https://reviews.llvm.org/D42036
https://reviews.llvm.org/D42035

I would prefer to do _something_ for the 6.0 release. Some options include:

a) review and submit the patches above to trunk and then and merge to the
release branch.
b) revert the feature for 6.0, keeping it on trunk.
c) document the known issues / mark the feature as experimental.


Referenced Bugs:

https://bugs.llvm.org/show_bug.cgi?id=35804
[Bug 35804] [meta] 6.0.0 Release Blockers
-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20180118/55b3cea9/attachment.html>


More information about the llvm-bugs mailing list