[llvm-bugs] [Bug 38439] New: MIR's -run-pass together with -verify-machineinstrs has strange behavior with function properties

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=38439

            Bug ID: 38439
           Summary: MIR's -run-pass together with -verify-machineinstrs
                    has strange behavior with function properties
           Product: libraries
           Version: trunk
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Common Code Generator Code
          Assignee: unassignedbugs at nondot.org
          Reporter: francisvm at yahoo.com
                CC: llvm-bugs at lists.llvm.org

Assuming you have this test case:

body:
  $rax = TARGET_PSEUDO

then the MIR parser will add NoPHIs, IsSSA and NoVRegs function properties.

If you run llc -run-pass expand-isel-pseudos -verify-machineinstrs, where
expand-isel-pseudos will expand TARGET_PSEUDO by adding either PHIs or vregs,
the machine verifier will complain about the function not respecting the NoPHIs
and NoVRegs properties.

I am not sure what the correct behavior should be here, but we should be able
to somehow force it in the MIR file so that we don't have to add actual PHI MIs
to the test.

A few possibilities:

* Properly implement
getClearedProperties/getSetProperties/getRequiredProperties for all the passes.
One issue here is that in the case of passes that call into backends, we don't
know the hooks will insert, so we'll end up clearing most of the properties in
many cases.
* Set/reset the properties from every pass including all the backend hooks.
* Add MIR keys that force the properties for the whole file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20180803/102124e1/attachment.html>