[llvm-bugs] [Bug 32569] CoroFrame inserts spills non-determinstically

via llvm-bugs llvm-bugs at lists.llvm.org
Thu May 25 19:03:01 PDT 2017


gornishanov at gmail.com changed:

           What    |Removed                     |Added
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from gornishanov at gmail.com ---
Thank you for the bug.

commit 3cc8445f85497cd1147c31d13ea4be1d2a629293
Author: Gor Nishanov <GorNishanov at gmail.com>
Date:   Sat Apr 8 00:49:46 2017 +0000

    [coroutines] Make CoroSplit pass deterministic

    coro-split-after-phi.ll test was flaky due to non-determinism in
    the coroutine frame construction that was sorting the spill
    vector using a pointer to a def as a part of the key.

    The sorting was intended to make sure that spills for the same def
    are kept together, however, we populate the vector by processing
    defs in order, so the spill entires will end up together anyways.

    This change removes spill sorting and restores the determinism
    in the test.

    git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@299809

You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20170526/b7bfbc75/attachment.html>

More information about the llvm-bugs mailing list