[llvm-bugs] [Bug 33759] New: clang-format-diff.py refex does not match correct file name

via llvm-bugs llvm-bugs at lists.llvm.org
Wed Jul 12 06:11:09 PDT 2017


https://bugs.llvm.org/show_bug.cgi?id=33759

            Bug ID: 33759
           Summary: clang-format-diff.py refex does not match correct file
                    name
           Product: clang
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P
         Component: Formatter
          Assignee: unassignedclangbugs at nondot.org
          Reporter: sauravshekhar01 at gmail.com
                CC: djasper at google.com, klimek at google.com,
                    llvm-bugs at lists.llvm.org

I am trying to use the clang-format-diff
(clang/tools/clang-format/clang-format-diff.py). In the current master version,
regex at line 68 of the file seems to capture the wrong filename. To elaborate,
this is an example output for `git diff -U0 HEAD^` command on my machine:


--- a/tmva/tmva/inc/TMVA/DNN/RNN/RNNLayer.h
+++ b/tmva/tmva/inc/TMVA/DNN/RNN/RNNLayer.h
@@ -29,2 +29,2 @@
-#ifndef TMVA_DNN_RNN_CELL
-#define TMVA_DNN_RNN_CELL
+#ifndef TMVA_DNN_RNN_LAYER
+#define TMVA_DNN_RNN_LAYER
@@ -55 +55 @@ template<typename Architecture_t>


On this output, the filename matcher is capturing filename as
b/tmva/tmva/inc/TMVA/DNN/RNN/RNNLayer.h while it should actually capture
tmva/tmva/inc/TMVA/DNN/RNN/RNNLayer.h

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20170712/89470c39/attachment.html>


More information about the llvm-bugs mailing list