[llvm-bugs] [Bug 30671] New: Improve lit's ability to kill a process and all its children via a wrapper class

via llvm-bugs llvm-bugs at lists.llvm.org
Tue Oct 11 21:12:24 PDT 2016


https://llvm.org/bugs/show_bug.cgi?id=30671

            Bug ID: 30671
           Summary: Improve lit's ability to kill a process and all its
                    children via a wrapper class
           Product: Test Suite
           Version: trunk
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: lit
          Assignee: unassignedbugs at nondot.org
          Reporter: modocache at gmail.com
                CC: daniel at zuster.org, llvm-bugs at lists.llvm.org
    Classification: Unclassified

(This task was copied from
https://reviews.llvm.org/diffusion/L/browse/llvm/tags/RELEASE_390/final/utils/lit/TODO.
It was originally written by Daniel Dunbar.)

Introduce a wrapper class that has a ``subprocess.Popen`` like interface but
also supports killing the process and all its children and use this for running
tests.  This would allow us to implement platform specific methods for killing
a process's children which is needed for a per test timeout. On POSIX platforms
we can use process groups and on Windows we can probably use job objects. This
would not only allow us to remove the dependency on the ``psutil`` module but
would also be more reliable as the ``lit.util.killProcessAndChildren()``
function which is currently used is potentially racey (e.g. it might not kill a
fork bomb completely).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20161012/e49f65da/attachment.html>


More information about the llvm-bugs mailing list