[LLVMbugs] [Bug 6006] New: Change ContentCache::getBuffer to support failure properly.

[bugzilla-daemon at cs.uiuc.edu]

http://llvm.org/bugs/show_bug.cgi?id=6006

           Summary: Change ContentCache::getBuffer to support failure
                    properly.
           Product: clang
           Version: unspecified
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Basic
        AssignedTo: unassignedclangbugs at nondot.org
        ReportedBy: daniel at zuster.org
                CC: clattner at apple.com, llvmbugs at cs.uiuc.edu,
                    dgregor at apple.com


Currently, PCH works by creating file and content cache entries for files in
the PCH, which may not actually exist on disk anymore. There is currently a
huge hack in ContentCache::getBuffer which just manufactures file contents if
the file is ever referenced and turns out not to exist. This should be fixed,
by changing ContentCache::getBuffer to return failures properly. Clients could
then give a nice error about an inconsistent PCH state being detected.

This is a large project, as it involves also adding failure support to all of
the APIs which may transitively use getBuffer, and updating all of their
clients. Notable clients include SourceManager::getCharacterData and
Preprocessor::getSpelling.


-- 
Configure bugmail: http://llvm.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.