[LLVMbugs] [Bug 6836] New: Fix broken tests in Makefiles for platforms without dynamic libs

bugzilla-daemon at llvm.org bugzilla-daemon at llvm.org
Wed Apr 14 11:25:25 PDT 2010


           Summary: Fix broken tests in Makefiles for platforms without
                    dynamic libs
           Product: new-bugs
           Version: trunk
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: new bugs
        AssignedTo: unassignedbugs at nondot.org
        ReportedBy: reeuwijk at few.vu.nl
                CC: llvmbugs at cs.uiuc.edu

The attached patch fixes two related bugs in the current trunk.

1) The current trunk version of Makefile.config has a list of platforms that do
not support dynamic libraries, and a variable TARGET_HAS_DYNAMIC_LIBS that is
supposedly only set if the platform does support dynamic libraries.

At least, that is the intention. Unfortunately, the current code does the exact
opposite, and only sets TARGET_HAS_DYNAMIC_LIBS if the platform /is/ in the
list. The attached patch corrects this by reversing the test (ifeq -> ifneq).

Also, I wonder if the test shouldn't look at TARGET_OS, instead of HOST_OS, as
is done now. I haven't changed that.

2) The two places where TARGET_HAS_DYNAMIC_LIBS are used also have their test
in reverse, meaning that parts of the code that require dynamic libraries are
only compiled if the variable is NOT set. The attached patch also fixes this.

Configure bugmail: http://llvm.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the llvm-bugs mailing list