[LLVMbugs] [Bug 5507] Visibility warning from gcc-4.4 when compiling DwarfDebug.cpp

[bugzilla-daemon at cs.uiuc.edu]

http://llvm.org/bugs/show_bug.cgi?id=5507


Nick Lewycky <nicholas at mxc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicholas at mxc.ca
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from Nick Lewycky <nicholas at mxc.ca>  2009-11-17 03:17:21 ---
Okay. So I applied *a* fix, but it might not be good enough: I removed
VISIBILITY_HIDDEN from the whole directory.

As far as I can tell, this is the right thing to do. Having a class contain a
member of hidden visibility is a real bug, if you every try to hand that class*
to someone else to use it. That rule affects the whole object hierarchy all the
way down. Either all of it needs to be hidden or none of it can be.

I also looked into other ways to mark things hidden. Anonymous namespaces are
the most obvious, but all of these hidden classes are used in more than one
translation unit. You can also put all of this stuff in a namespace debug
VISIBILITY_HIDDEN, but it's still all subject to the hierarchy rule mentioned
above.

If the extra symbols are a real, non-cosmetic problem, please reopen this bug!


-- 
Configure bugmail: http://llvm.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.