[LLVMbugs] [Bug 1726] New: Could remove a getTargetNode variant

bugzilla-daemon at cs.uiuc.edu bugzilla-daemon at cs.uiuc.edu
Wed Oct 10 13:09:09 PDT 2007


http://llvm.org/bugs/show_bug.cgi?id=1726

           Summary: Could remove a getTargetNode variant
           Product: new-bugs
           Version: unspecified
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: new bugs
        AssignedTo: unassignedbugs at nondot.org
        ReportedBy: dalej at apple.com
                CC: llvmbugs at cs.uiuc.edu


This pattern in the PPC back end

def PPCmffs   : SDNode<"PPCISD::MFFS", SDTypeProfile<1, 0, [SDTCisVT<0, f64>]>,
                        [SDNPOutFlag]>;

def MFFS   : XForm_42<63, 583, (outs F8RC:$rT), (ins),
                       "mffs $rT", IntMFFS,
                       [(set F8RC:$rT, (PPCmffs))]>,
             PPC970_DGroup_Single, PPC970_Unit_FPU;

has 2 outputs and no inputs.   tblgen generates a call to 

 SDNode *getTargetNode(unsigned Opcode, MVT::ValueType VT1, MVT::ValueType
VT2);

which did not exist until I added it.   It is possible to use

*getTargetNode(unsigned Opcode, MVT::ValueType VT1,  MVT::ValueType VT2,
 const SDOperand *Ops, unsigned NumOps);

which would remove the need for the new function.
(This does not strike me as a big deal; filing here because Evan asked for it.)


-- 
Configure bugmail: http://llvm.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the llvm-bugs mailing list