[LLVMbugs] [PATCH] Remove useless workaround from llvm-config

[Reid Spencer]

Eric,

I've implemented something in Makefile.rules that will help you figure
out "useful" sets of things to implement in llvm-config. The new
facility is described here:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-
Mon-20060320/033195.html

It allows you to specify, in a Makefile:

LLVMLIBS := config --libs <components>

which invokes 'llvm-config --libs <components>' to derive the library
names that should be linked against.  The problem is: it doesn't work
for even something like Fibonacci. Could you apply this patch to
example/Fibonacci/Makefile:

Index: Makefile
===================================================================
RCS file: /var/cvs/llvm/llvm/examples/Fibonacci/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile    29 Nov 2004 07:17:19 -0000      1.7
+++ Makefile    24 Mar 2006 08:02:43 -0000
@@ -12,6 +12,7 @@
 EXAMPLE_TOOL = 1

 # Enable JIT support
-LLVMLIBS := JIT
+LLVMLIBS = config --libs engine
+#LLVMLIBS = JIT

 include $(LEVEL)/Makefile.common

and figure out either what's wrong with llvm-config or what's wrong with
the LLVMLIBS specification?

My goal here is to convert all the standard JIT programs (lli,examples)
to use the "config" specification instead of the JIT keyword for
LLVMLIBS and just kill the "JIT" support setion of Makefile.rules.
However, it seems there is some logic in Makefile.rules that is
currently escaping llvm-config. Could you implement the Makefile.rules
logic in llvm-config? See Makefile.rules in the ifeq($(LLVMLIBS),JIT)
conditional.

Thanks,

Reid.

On Thu, 2006-03-23 at 20:06 -0500, Eric Kidd wrote:
> Reid, this removes the useless workaround.
> 
> Cheers,
> Eric
> 
> _______________________________________________
> LLVMbugs mailing list
> LLVMbugs at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmbugs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20060324/605c3f51/attachment.sig>