[LLVMbugs] [PATCH] misleading comments in include/llvm/Module.h

Marco Matthies marco-ml at gmx.net
Sat Jan 7 18:17:24 PST 2006


Hi,

these comments seem to stem from a time when Endianess and PointerSize 
were bools (or enums that behaved like bools).

Marco

Index: include/llvm/Module.h
===================================================================
RCS file: /var/cvs/llvm/llvm/include/llvm/Module.h,v
retrieving revision 1.65
diff -u -r1.65 Module.h
--- include/llvm/Module.h       5 Dec 2005 05:30:21 -0000       1.65
+++ include/llvm/Module.h       8 Jan 2006 02:07:16 -0000
@@ -73,11 +73,8 @@
    SymbolTable *SymTab;           // Symbol Table for the module
    std::string ModuleID;          // Human readable identifier for the 
module
    std::string TargetTriple;      // Platform target triple Module 
compiled on
-
-  // These flags are probably not the right long-term way to handle 
this kind of
-  // target information, but it is sufficient for now.
-  Endianness  Endian;     // True if target is little endian
-  PointerSize PtrSize;    // True if target has 32-bit pointers (false 
= 64-bit)
+  Endianness  Endian;            // Endianness assumed in the module
+  PointerSize PtrSize;           // Pointer size assumed in the module

    friend class Constant;




More information about the llvm-bugs mailing list