[llvm-branch-commits] [llvm-branch] r366758 - Merging r366527:

[Hans Wennborg via llvm-branch-commits]

Author: hans
Date: Mon Jul 22 15:33:29 2019
New Revision: 366758

URL: http://llvm.org/viewvc/llvm-project?rev=366758&view=rev
Log:
Merging r366527:
------------------------------------------------------------------------
r366527 | abrachet | 2019-07-19 04:31:21 +0200 (Fri, 19 Jul 2019) | 13 lines

[test] [llvm-objcopy] Fix broken test case

Summary: The test case added in D62718 did not work unless the user was root because write bits were not set for the output file. This change uses only permissions with user write (0200) to ensure tests pass regardless of the users permissions.

Reviewers: jhenderson, rupprecht, MaskRay, espindola, alexshap

Reviewed By: MaskRay

Subscribers: emaste, arichardson, jakehehrlich, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64302
------------------------------------------------------------------------

Modified:
    llvm/branches/release_90/   (props changed)
    llvm/branches/release_90/test/tools/llvm-objcopy/ELF/respect-umask.test

Propchange: llvm/branches/release_90/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jul 22 15:33:29 2019
@@ -1,3 +1,3 @@
 /llvm/branches/Apple/Pertwee:110850,110961
 /llvm/branches/type-system-rewrite:133420-134817
-/llvm/trunk:155241,366431,366481,366570
+/llvm/trunk:155241,366431,366481,366527,366570

Modified: llvm/branches/release_90/test/tools/llvm-objcopy/ELF/respect-umask.test
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/release_90/test/tools/llvm-objcopy/ELF/respect-umask.test?rev=366758&r1=366757&r2=366758&view=diff
==============================================================================
--- llvm/branches/release_90/test/tools/llvm-objcopy/ELF/respect-umask.test (original)
+++ llvm/branches/release_90/test/tools/llvm-objcopy/ELF/respect-umask.test Mon Jul 22 15:33:29 2019
@@ -9,18 +9,25 @@
 # RUN: touch %t
 # RUN: chmod 0755 %t
 # RUN: ls -l %t | cut -f 1 -d ' ' > %t.0755
-# RUN: chmod 0500 %t
-# RUN: ls -l %t | cut -f 1 -d ' ' > %t.0500
-# RUN: chmod 0555 %t
-# RUN: ls -l %t | cut -f 1 -d ' ' > %t.0555
+# RUN: chmod 0600 %t
+# RUN: ls -l %t | cut -f 1 -d ' ' > %t.0600
+# RUN: chmod 0655 %t
+# RUN: ls -l %t | cut -f 1 -d ' ' > %t.0655
 
-# RUN: rm -f %t; yaml2obj %s -o %t
+# RUN: yaml2obj %s -o %t
 
 # RUN: umask 0022
 # RUN: chmod 0777 %t
-# RUN: rm -f %t1; llvm-objcopy %t %t1
-# RUN: ls -l %t1 | cut -f 1 -d ' ' > %t1.perms
-# RUN: cmp %t1.perms %t.0755
+# RUN: llvm-objcopy %t %t1
+# RUN: ls -l %t1 | cut -f 1 -d ' ' | cmp - %t.0755
+
+# RUN: umask 0177
+# RUN: llvm-objcopy %t %t2
+# RUN: ls -l %t2 | cut -f 1 -d ' ' | cmp - %t.0600
+
+# RUN: umask 0122
+# RUN: llvm-objcopy %t %t3
+# RUN: ls -l %t3 | cut -f 1 -d ' ' | cmp - %t.0655
 
 --- !ELF
 FileHeader: