[llvm-branch-commits] [llvm-branch] r344805 - Merging r343428:

Tom Stellard via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Oct 19 12:14:17 PDT 2018


Author: tstellar
Date: Fri Oct 19 12:14:17 2018
New Revision: 344805

URL: http://llvm.org/viewvc/llvm-project?rev=344805&view=rev
Log:
Merging r343428:

------------------------------------------------------------------------
r343428 | ctopper | 2018-09-30 16:43:30 -0700 (Sun, 30 Sep 2018) | 3 lines

[X86] Change an llvm_unreachable to a report_fatal_error so the optimizer will stop making us reach the other report_fatal_error in this function.

There's a conditional report_fatal_error just above this llvm_unreachable. The optimizer when seeing the unreachable removes the conditional and just makes any other error trigger the existing report_fatal_error.
------------------------------------------------------------------------

Modified:
    llvm/branches/release_70/lib/Target/X86/X86InstrInfo.cpp

Modified: llvm/branches/release_70/lib/Target/X86/X86InstrInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/release_70/lib/Target/X86/X86InstrInfo.cpp?rev=344805&r1=344804&r2=344805&view=diff
==============================================================================
--- llvm/branches/release_70/lib/Target/X86/X86InstrInfo.cpp (original)
+++ llvm/branches/release_70/lib/Target/X86/X86InstrInfo.cpp Fri Oct 19 12:14:17 2018
@@ -3109,7 +3109,7 @@ void X86InstrInfo::copyPhysReg(MachineBa
 
   LLVM_DEBUG(dbgs() << "Cannot copy " << RI.getName(SrcReg) << " to "
                     << RI.getName(DestReg) << '\n');
-  llvm_unreachable("Cannot emit physreg copy instruction");
+  report_fatal_error("Cannot emit physreg copy instruction");
 }
 
 bool X86InstrInfo::isCopyInstr(const MachineInstr &MI,




More information about the llvm-branch-commits mailing list