[llvm-branch-commits] [llvm-branch] r206055 - Merging r205067:

[Tom Stellard]

Author: tstellar
Date: Fri Apr 11 14:35:44 2014
New Revision: 206055

URL: http://llvm.org/viewvc/llvm-project?rev=206055&view=rev
Log:
Merging r205067:

------------------------------------------------------------------------
r205067 | ahatanaka | 2014-03-28 19:28:07 -0400 (Fri, 28 Mar 2014) | 7 lines

[x86] Fix printing of register operands with q modifier.

Emit 32-bit register names instead of 64-bit register names if the target does
not have 64-bit general purpose registers.

<rdar://problem/14653996>

------------------------------------------------------------------------

Added:
    llvm/branches/release_34/test/CodeGen/X86/inline-asm-modifier-q.ll
Modified:
    llvm/branches/release_34/lib/Target/X86/X86AsmPrinter.cpp

Modified: llvm/branches/release_34/lib/Target/X86/X86AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/release_34/lib/Target/X86/X86AsmPrinter.cpp?rev=206055&r1=206054&r2=206055&view=diff
==============================================================================
--- llvm/branches/release_34/lib/Target/X86/X86AsmPrinter.cpp (original)
+++ llvm/branches/release_34/lib/Target/X86/X86AsmPrinter.cpp Fri Apr 11 14:35:44 2014
@@ -393,9 +393,11 @@ bool X86AsmPrinter::printAsmMRegister(co
   case 'k': // Print SImode register
     Reg = getX86SubSuperRegister(Reg, MVT::i32);
     break;
-  case 'q': // Print DImode register
-    // FIXME: gcc will actually print e instead of r for 32-bit.
-    Reg = getX86SubSuperRegister(Reg, MVT::i64);
+  case 'q':
+    // Print 64-bit register names if 64-bit integer registers are available.
+    // Otherwise, print 32-bit register names.
+    MVT::SimpleValueType Ty = Subtarget->is64Bit() ? MVT::i64 : MVT::i32;
+    Reg = getX86SubSuperRegister(Reg, Ty);
     break;
   }
 

Added: llvm/branches/release_34/test/CodeGen/X86/inline-asm-modifier-q.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/release_34/test/CodeGen/X86/inline-asm-modifier-q.ll?rev=206055&view=auto
==============================================================================
--- llvm/branches/release_34/test/CodeGen/X86/inline-asm-modifier-q.ll (added)
+++ llvm/branches/release_34/test/CodeGen/X86/inline-asm-modifier-q.ll Fri Apr 11 14:35:44 2014
@@ -0,0 +1,12 @@
+; RUN: llc < %s -march=x86  | FileCheck %s
+
+; If the target does not have 64-bit integer registers, emit 32-bit register
+; names.
+
+; CHECK: movq (%e{{[abcd]}}x, %ebx, 4)
+
+define void @q_modifier(i32* %p) {
+entry:
+  tail call void asm sideeffect "movq (${0:q}, %ebx, 4), %mm0", "r,~{dirflag},~{fpsr},~{flags}"(i32* %p)
+  ret void
+}