[llvm-branch-commits] [cfe-branch] r103042 - /cfe/branches/Apple/whitney-IB/ClangBNI.mk

[Daniel Dunbar]

Author: ddunbar
Date: Tue May  4 15:39:09 2010
New Revision: 103042

URL: http://llvm.org/viewvc/llvm-project?rev=103042&view=rev
Log:
Tweak update-sources to require an explicit REVISION argument, and tidy up error checking.

Modified:
    cfe/branches/Apple/whitney-IB/ClangBNI.mk

Modified: cfe/branches/Apple/whitney-IB/ClangBNI.mk
URL: http://llvm.org/viewvc/llvm-project/cfe/branches/Apple/whitney-IB/ClangBNI.mk?rev=103042&r1=103041&r2=103042&view=diff
==============================================================================
--- cfe/branches/Apple/whitney-IB/ClangBNI.mk (original)
+++ cfe/branches/Apple/whitney-IB/ClangBNI.mk Tue May  4 15:39:09 2010
@@ -214,41 +214,45 @@
 SVN_TAGS = $(SVN_BASE)/cfe/tags/Apple
 
 update-sources:
+	@if ! [ -n "$(REVISION)" ]; then \
+	  echo Usage: make $@ REVISION=102052; \
+	  false; \
+	fi
 	svn rm -m 'Update.' $(SVN_CLANG)/src
-	svn cp -m 'Update.' $(SVN_BASE)/llvm/trunk $(SVN_CLANG)/src
-	svn cp -m 'Update.' $(SVN_BASE)/cfe/trunk $(SVN_CLANG)/src/tools/clang
-	svn cp -m 'Update.' $(SVN_BASE)/compiler-rt/trunk $(SVN_CLANG)/src/projects/compiler-rt
+	svn cp -m 'Update.' $(SVN_BASE)/llvm/trunk@$(REVISION) $(SVN_CLANG)/src
+	svn cp -m 'Update.' $(SVN_BASE)/cfe/trunk@$(REVISION) $(SVN_CLANG)/src/tools/clang
+	svn cp -m 'Update.' $(SVN_BASE)/compiler-rt/trunk@$(REVISION) $(SVN_CLANG)/src/projects/compiler-rt
 	svn up
 
 tag-clang:
-	if [ -n "$(VERSION)" ]; then \
-	  svn cp -m 'Tag.' $(SVN_CLANG) $(SVN_TAGS)/clang-$(VERSION); \
-	else \
-	  echo Usage: make VERSION=25 tag-clang; \
+	@if ! [ -n "$(VERSION)" ]; then \
+	  echo Usage: make $@ VERSION=25; \
+	  false; \
 	fi
+	svn cp -m 'Tag.' $(SVN_CLANG) $(SVN_TAGS)/clang-$(VERSION)
 
 retag-clang:
-	if [ -n "$(VERSION)" ]; then \
-	  svn rm -m 'Retag.' $(SVN_TAGS)/clang-$(VERSION) && \
-	  svn cp -m 'Retag.' $(SVN_CLANG) $(SVN_TAGS)/clang-$(VERSION); \
-	else \
-	  echo Usage: make VERSION=25 retag-clang; \
+	@if ! [ -n "$(VERSION)" ]; then \
+	  echo Usage: make $@ VERSION=25; \
+	  false; \
 	fi
+	svn rm -m 'Retag.' $(SVN_TAGS)/clang-$(VERSION)
+	svn cp -m 'Retag.' $(SVN_CLANG) $(SVN_TAGS)/clang-$(VERSION)
 
 tag-clang_ide:
-	if [ -n "$(VERSION)" ]; then \
-	  svn cp -m 'Tag.' $(SVN_CLANG) $(SVN_TAGS)/clang_ide-$(VERSION); \
-	else \
-	  echo Usage: make VERSION=25 tag-clang_ide; \
+	@if ! [ -n "$(VERSION)" ]; then \
+	  echo Usage: make $@ VERSION=25; \
+	  false; \
 	fi
+	svn cp -m 'Tag.' $(SVN_CLANG) $(SVN_TAGS)/clang_ide-$(VERSION)
 
 retag-clang_ide:
-	if [ -n "$(VERSION)" ]; then \
-	  svn rm -m 'Retag.' $(SVN_TAGS)/clang_ide-$(VERSION) && \
-	  svn cp -m 'Retag.' $(SVN_CLANG) $(SVN_TAGS)/clang_ide-$(VERSION); \
-	else \
-	  echo Usage: make VERSION=25 retag-clang_ide; \
+	@if ! [ -n "$(VERSION)" ]; then \
+	  echo Usage: make $@ VERSION=25; \
+	  false; \
 	fi
+	svn rm -m 'Retag.' $(SVN_TAGS)/clang_ide-$(VERSION) && \
+	svn cp -m 'Retag.' $(SVN_CLANG) $(SVN_TAGS)/clang_ide-$(VERSION); \
 
 ##
 # Additional Tool Paths