<div dir="ltr"><div dir="ltr">On Tue, May 18, 2021 at 6:50 AM Krzysztof Parzyszek <<a href="mailto:kparzysz@quicinc.com">kparzysz@quicinc.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US" style="overflow-wrap: break-word;">
<div class="gmail-m_4065269081265090465WordSection1">
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext" style="margin-left:1in">Post-commit reviews are conducted, in order of preference, on Phabricator,
<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in">This still seems like a change in practice that I'm not in favor of, personally - due to the current divergence between email and phab review feedback. Yes, this would be one way to unify it - but I'm not sure it's
necessarily the best one.<br>
<br>
I'd suggest leaving this to a separate proposal so as not to complicate/muddy the waters of the formalization of pre-commit review practice.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">I simply broke up the existing sentence from the documentation into two parts, one about pre-commit reviews and the other about all other code reviews (which are basically the post-commit reviews, although I’m open to corrections here).
The first part was modified to reflect the proposed change, the second part was left unchanged. </p></div></div></blockquote><div><br>I think the issue is that the original phrasing was probably only intended to describe the preference for pre-commit review. (I think statements about post-commit review could reasonably read to be only those that say "post-commit review", in this ( <a href="https://llvm.org/docs/CodeReview.html#can-code-be-reviewed-after-it-is-committed">https://llvm.org/docs/CodeReview.html#can-code-be-reviewed-after-it-is-committed</a> ) section. <br><br>So I think (at least in terms of how to read it in a way that matches existing practice) the original wording amounted to something like this:<br><br>... "post-commit review can use any of the tools listed below" ... <br>... "pre-commit review is done in this order of phab, email, etc... "<br><br>ie: the post-commit review didn't have the same order of preference as pre-commit review.<br><br>I'd probably pull out the post-commit review-specific wording back up to where post-commit review is discussed, and leave the rest of this to talk about pre-commit review (most of this document discussing unqualified "review" seems predominantly to be talking about "pre-commit review" except the part that talks about "post commit review").<br><br>Probably move the "on our web-based code-review tool (see Code Reviews with Phabricator), by email on the relevant project’s commit mailing list, on the project’s development list, or on the bug tracker." (without the "in order of preference") up to the "post-commit review" section, instead of referencing a version of it here.<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-US" style="overflow-wrap: break-word;"><div class="gmail-m_4065269081265090465WordSection1"><p class="MsoNormal"> In this RFC I only want to change the part of the documentation that pertains specifically to pre-commit code reviews. If the wording I used creates confusion,
what would you suggest instead?<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span style="font-size:9pt;font-family:Consolas">-- </span>
<span style="font-size:9pt;font-family:Consolas"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:8pt;font-family:Consolas">Krzysztof Parzyszek
<a href="mailto:kparzysz@quicinc.com" target="_blank"><span style="color:rgb(5,99,193)">kparzysz@quicinc.com</span></a> AI tools development<u></u><u></u></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> <br>
<b>Sent:</b> Monday, May 17, 2021 4:40 PM<br>
<b>To:</b> Krzysztof Parzyszek <<a href="mailto:kparzysz@quicinc.com" target="_blank">kparzysz@quicinc.com</a>><br>
<b>Cc:</b> llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>; <a href="mailto:clangd-dev@lists.llvm.org" target="_blank">clangd-dev@lists.llvm.org</a>; <a href="mailto:openmp-dev@lists.llvm.org" target="_blank">openmp-dev@lists.llvm.org</a>; <a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>; <a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>; <a href="mailto:libcxx-dev@lists.llvm.org" target="_blank">libcxx-dev@lists.llvm.org</a>; <a href="mailto:flang-dev@lists.llvm.org" target="_blank">flang-dev@lists.llvm.org</a>; <a href="mailto:parallel_libs-dev@lists.llvm.org" target="_blank">parallel_libs-dev@lists.llvm.org</a><br>
<b>Subject:</b> [EXT] Re: [cfe-dev] [RFC] Deprecate pre-commit email code reviews in favor of Phabricator<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Mon, May 17, 2021 at 11:12 AM Krzysztof Parzyszek via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">This is a revision of the previous RFC[1]. This RFC limits the scope to pre-commit reviews only.<u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"> <u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"><b>Statement:</b><u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">Our current code review policy states[2]:<u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext" style="margin-left:0.5in">“Code reviews are conducted, in order of preference, on our web-based code-review tool (see Code Reviews with Phabricator), by email on the relevant project’s commit mailing list, on
the project’s development list, or on the bug tracker.”<u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">This proposal is to limit pre-commit code reviews only to Phabricator. This would apply to all projects in the LLVM monorepo. With the change in effect, the amended policy would read:<u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext" style="margin-left:0.5in">“Pre-commit code reviews are conducted on our web-based code-review tool (see Code Reviews with Phabricator). <u></u><u></u></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal">I'm with you here ^, this seems to document/formalize existing practice - though does this accurately reflect all the projects in the mororepo? I get the impression that mlir, maybe flang, etc might be doing reviews differently? <u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext" style="margin-left:0.5in">Post-commit reviews are conducted, in order of preference, on Phabricator,
<u></u><u></u></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal">This still seems like a change in practice that I'm not in favor of, personally - due to the current divergence between email and phab review feedback. Yes, this would be one way to unify it - but I'm not sure it's necessarily the best
one.<br>
<br>
I'd suggest leaving this to a separate proposal so as not to complicate/muddy the waters of the formalization of pre-commit review practice.<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext" style="margin-left:0.5in">by email on the relevant project’s commit mailing list, on the project’s development list, or on the bug tracker.”<u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"> <u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"><b>Current situation:</b><u></u><u></u></p>
<ol start="1" type="1">
<li class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">
In a recent llvm-dev thread[3], Christian Kühnel pointed out that pre-commit code reviews rarely originate via an email (most are started on Phabricator), although, as others pointed out, email responses to an ongoing review are not uncommon. (That thread
also contains examples of mishaps related to the email-Phabricator interactions, or email handling itself.)<u></u><u></u></li><li class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">
We have Phabricator patches that automatically apply email comments to the Phabricator reviews, although reportedly this functionality is not fully reliable[4,5]. This can cause review comments to be lost in the email traffic.<u></u><u></u></li></ol>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"> <u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"><b>Benefits:</b><u></u><u></u></p>
<ol start="1" type="1">
<li class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">
Single way of doing pre-commit code reviews: these code reviews are a key part of the development process, and having one way of performing them would make the process clearer and unambiguous.<u></u><u></u></li><li class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">
Review authors and reviewers would only need to monitor one source of comments without the fear that a review comment may end up overlooked.<u></u><u></u></li><li class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">
This change simply codifies an existing practice.<u></u><u></u></li></ol>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"> <u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"><b>Concerns:</b><u></u><u></u></p>
<ol start="1" type="1">
<li class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">
Because of the larger variety, email clients may offer better accessibility options than web browsers.
<u></u><u></u></li></ol>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"> <u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"> <u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">[1] <a href="https://lists.llvm.org/pipermail/llvm-dev/2021-May/150344.html" target="_blank">
https://lists.llvm.org/pipermail/llvm-dev/2021-May/150344.html</a><u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">[2] <a href="https://llvm.org/docs/CodeReview.html#what-tools-are-used-for-code-review" target="_blank">
https://llvm.org/docs/CodeReview.html#what-tools-are-used-for-code-review</a><u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">[3] <a href="https://lists.llvm.org/pipermail/llvm-dev/2021-April/150129.html" target="_blank">
https://lists.llvm.org/pipermail/llvm-dev/2021-April/150129.html</a><u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">[4] <a href="https://lists.llvm.org/pipermail/llvm-dev/2021-April/150136.html" target="_blank">
https://lists.llvm.org/pipermail/llvm-dev/2021-April/150136.html</a><u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">[5] <a href="https://lists.llvm.org/pipermail/llvm-dev/2021-April/150139.html" target="_blank">
https://lists.llvm.org/pipermail/llvm-dev/2021-April/150139.html</a><u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"> <u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"> <u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">-- <u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext">Krzysztof Parzyszek <a href="mailto:kparzysz@quicinc.com" target="_blank">
kparzysz@quicinc.com</a> AI tools development<u></u><u></u></p>
<p class="gmail-m_4065269081265090465gmail-m8924233148030043466msoplaintext"> <u></u><u></u></p>
</div>
</div>
<p class="MsoNormal">_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote></div></div>