<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">We spoke a bit after Panel's comments which made sense and we propose the commands Walter sent below. Let us know what everyone thinks of this organization of the command structure!<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 1, 2020, at 1:32 PM, Walter <<a href="mailto:a20012251@gmail.com" class="">a20012251@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">After a chat with Greg, we agreed on this set of commands<div class=""><br class=""></div><div class=""><br class=""><span style="color:rgb(35,34,34);font-family:Menlo,Consolas,Monaco,monospace;font-size:15px;white-space:pre-wrap;background-color:rgba(255,255,255,0.5)" class="">trace load /path/to/json
process trace start/stop
process trace save /path/to/json
thread trace start/stop
thread trace dump [instructions | functions]
</span><br class="gmail-Apple-interchange-newline"></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Il giorno gio 1 ott 2020 alle ore 13:21 Greg Clayton <<a href="mailto:clayborg@gmail.com" class="">clayborg@gmail.com</a>> ha scritto:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br class="">
<br class="">
> On Oct 1, 2020, at 7:08 AM, Pavel Labath via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank" class="">lldb-dev@lists.llvm.org</a>> wrote:<br class="">
> <br class="">
> Thank you for writing this Walter. I think this document will be a<br class="">
> useful reference both now and in the future.<br class="">
> <br class="">
> The part that's not clear to me is what is the story with multi-process<br class="">
> traces. The file format enables those, but it's not clear how are they<br class="">
> going be created or used. Can you elaborate more on what you intend to<br class="">
> use those for?<br class="">
<br class="">
Mainly for system trace kinds of things where an entire system gets traced.<br class="">
<br class="">
> <br class="">
> The main reason I am asking that is because I am thinking about the<br class="">
> proposed command structure. I'm wondering if it would not be better to<br class="">
> fit this into the existing target/process/thread commands instead of<br class="">
> adding a new top-level command. For example, one could imagine the<br class="">
> following set of commands:<br class="">
> <br class="">
> - "process trace start" + "thread trace start" instead of "thread trace<br class="">
> [tid]". That would be similar to "process continue" + "thread continue".<br class="">
> - "thread trace dump [tid]" instead of "trace dump [-t tid]". That would<br class="">
> be similar to "thread continue" and other thread control commands.<br class="">
> - "target create --trace" instead of "trace load". (analogous to target<br class="">
> create --core).<br class="">
> - "process trace save" instead of "trace save" -- (mostly) analogous to<br class="">
> "process save-core"<br class="">
<br class="">
> I am thinking this composition may fit in better into the existing lldb<br class="">
> command landscape, though I also see the appeal in grouping everything<br class="">
> trace-related under a single top-level command. What do you think?<br class="">
> <br class="">
> The main place where this idea breaks down is the multi-process traces.<br class="">
> While we could certainly make "target create --trace" create multiple<br class="">
> targets, that would be fairly unusual. OTOH, the whole concept of having<br class="">
> multiple targets share something is a pretty unusual thing for lldb.<br class="">
> That's why I'd like to hear more about where you want to go with this idea.<br class="">
<br class="">
I kind of see tracing has having two sides:<br class="">
1 - post mortem tracing for individual or multiple processes<br class="">
2 - live debug session tracing for being able to see how you crashed where trace data is for current process only<br class="">
<br class="">
For post mortem tracing, the trace top level command seemed to make sense here because there are no other target commands that act on more than one target. So "trace load" makes sense to me here for loading one or more traces. The idea is the trace JSON file has enough info to completely load up the state of the trace so we can symbolicate, dump and step around in history. So I would vote to keep "trace load" at the very least because it can create one or more targets. Options can be added to display the processes if needed:<br class="">
<br class="">
(lldb) trace list <trace-json-file><br class="">
<br class="">
But we could move "trace dump" over into "target trace dump" or "process trace dump" since that is effectively how we are coding these patches.<br class="">
<br class="">
For live debugging where we gather trace data through the process plug-in, we will have a live process that may or may not have trace data. If tracing isn't available we will not be able to dump anything. But I would like to see process/thread commands for this scenario:<br class="">
<br class="">
- process trace start/stop (only succeeds if we can gather trace data through the process plug-in)<br class="">
- thread trace start/stop (which can succeed only if current tracing can enable tracing for only one thread)<br class="">
<br class="">
Not sure if we need "process trace save" or "thread trace save" as the saving can be done as an option to "process trace stop --save /path/to/save"<br class="">
<br class="">
So I am all for fitting these commands in where they need to go.<br class="">
<br class="">
> <br class="">
> On 21/09/2020 22:17, Walter via lldb-dev wrote:<br class="">
>> Thanks for your feedback Fangrui, I've just been checking Capn' Proto<br class="">
>> and it looks really good. I'll keep it in mind in the design and see how<br class="">
>> it can optimize the overall data transfer.<br class="">
> <br class="">
> I'm not sure how Cap'n Proto comes into play here. The way I understand<br class="">
> it, the real data is contained in a separate file in the specialized<br class="">
> intel format and the json is just for the metadata. I'd expect the<br class="">
> metadata file to be small even for enormous traces, so I'm not sure<br class="">
> what's to be gained by optimizing it.<br class="">
> <br class="">
> pl<br class="">
> <br class="">
> _______________________________________________<br class="">
> lldb-dev mailing list<br class="">
> <a href="mailto:lldb-dev@lists.llvm.org" target="_blank" class="">lldb-dev@lists.llvm.org</a><br class="">
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br class="">
<br class="">
</blockquote></div><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class="gmail_signature"><div dir="ltr" class=""><div class="">- Walter ErquÃnigo Pezo<br class=""><br class=""></div></div></div>
</div></blockquote></div><br class=""></body></html>