<div dir="ltr">Ug. After a rebase, this problem has again resurfaced for me.<div><br></div><div>* PATH has only C:\Python36</div><div></div><div>* cmake version 3.15.19101501-MSVC_2</div><div>* cmake -GNinja -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON -DCMAKE_BUILD_TYPE=Debug -DLLDB_TEST_DEBUG_TEST_CRASHES=1 -<span style="background-color:rgb(255,255,0)">DPYTHON_HOME=C:\Python36 -DLLDB_PYTHON_HOME=C:\Python36 -DPython3_ROOT_DIR=C:\Python36</span> -DLLDB_TEST_COMPILER=D:\src\llvm\build\ninja_dbg\bin\clang.exe ..\..\llvm-project\llvm -DLLVM_ENABLE_ZLIB=OFF -DLLVM_ENABLE_PROJECTS="clang;lld;lldb;debuginfo-tests"</div><div><br></div>Yet when linking LLDB, it goes looking at the Python 3.7 installation that comes with Visual Studio. That wouldn't be much of a problem unless you're trying to build debug, which I am. The VS version, doesn't come with debug versions of the interpreter libraries, so the link fails:<div><br></div><div><font face="monospace" size="1">[1/7] Linking CXX shared library bin\liblldb.dll<br>FAILED: bin/liblldb.dll lib/liblldb.lib<br>cmd.exe /C "cd . && "C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -E vs_link_dll --intdir=tools\lldb\source\API\CMakeFiles\liblldb.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\mt.exe --manifests -- C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\liblldb.rsp /out:bin\liblldb.dll /implib:lib\liblldb.lib /pdb:bin\liblldb.pdb /dll /version:11.0 /machine:x64 /debug /INCREMENTAL && cd ."<br>LINK Pass 1: command "C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\liblldb.rsp /out:bin\liblldb.dll /implib:lib\liblldb.lib /pdb:bin\liblldb.pdb /dll /version:11.0 /machine:x64 /debug /INCREMENTAL /MANIFEST /MANIFESTFILE:tools\lldb\source\API\CMakeFiles\liblldb.dir/intermediate.manifest tools\lldb\source\API\CMakeFiles\liblldb.dir/manifest.res" failed (exit code 1104) with the following output:<br>LINK : fatal error LNK1104: cannot open file '<span style="background-color:rgb(255,255,0)">python37_d.lib</span>'<br>ninja: build stopped: subcommand failed.</font><br></div><div><font face="monospace" size="1"><br></font></div><div><font face="arial, sans-serif">It looks like Cmake has added<a href="https://cmake.org/cmake/help/v3.15/module/FindPython3.html#hints"> several more hints for finding Python</a>. I'm trying now with -D</font>Python3_FIND_REGISTRY=LAST.</div><div><br></div><div>I miss hermetic builds.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 27, 2020 at 11:33 AM Adrian McCarthy <<a href="mailto:amccarth@google.com">amccarth@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">>
This was all fixed in CMake 3.12.<div><br></div><div>For some definitions of "all fixed." ;-)</div><div><div><br></div><div>It seems weird to me that FindPython3 found the VS-distributed Python, which isn't mentioned anywhere in the environment block, and that it chose that one over the Python 3 installation that was in the path and that included the interpreters and all of the corresponding libraries.</div><div><br></div><div>>
With FindPython{2,3} you know you'll have a matching interpreter and library.
</div><div><br></div><div></div></div><div>The build failure was that the Python distributed in VS does not have a debug version of the library (python37_d.lib), so you don't actually get a matching interpreter and library for debug builds.</div><div><br></div><div>It's also not clear whether LLVM was consistently using the Python found the old way. My generated build.ninja file seemed to be using both versions inconsistently to run lit tests and the like.</div><div><br></div><div>Anyway, thanks for the explanations. I've LGTMed your patch, which should eliminate future surprises when something else smuggles yet another version of Python onto a machine.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 27, 2020 at 11:14 AM Jonas Devlieghere <<a href="mailto:jonas@devlieghere.com" target="_blank">jonas@devlieghere.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div>So to make my previous explanation more concrete:</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 27, 2020 at 11:05 AM Jonas Devlieghere <<a href="mailto:jonas@devlieghere.com" target="_blank">jonas@devlieghere.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 27, 2020 at 10:53 AM Adrian McCarthy <<a href="mailto:amccarth@google.com" target="_blank">amccarth@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Thanks for the info. Setting Python3_ROOT_DIR solves the problem.<div><br></div><div><div>Looking at the cmake output from before setting Python3_ROOT_DIR, cmake looks for Python twice and finds it at the two different locations.</div><div><br></div><div>Early on:</div><div><br></div><div>-- Found PythonInterp: C:/Python36/python.exe (found version "3.6.8")<br></div></div></div></blockquote></div></div></blockquote><div><br></div><div>^ This is using the "old" (CMake < 3.12) way of finding the Python interpreter.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div></div><div><br></div><div>Which looks good (modulo the incorrect slash direction). But later:</div><div><br></div><div>-- Found Python3: C:/Program Files (x86)/Microsoft Visual Studio/Shared/Python37_64/python.exe (found version "3.7.5") found components: Interpreter Development<br>-- Found PythonInterpAndLibs: C:/Program Files (x86)/Microsoft Visual Studio/Shared/Python37_64/libs/python37.lib<br></div></div></div></blockquote></div></div></blockquote><div><br></div><div>^ This is using the "new" (CMake > 3.12) way of finding the Python interpreter and libraries. </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div></div><div><br></div><div>Which is where the discrepancy comes in. Note that only C:\Python36 is in my PATH.</div></div><div><br></div><div>It's frustrating that this keeps breaking. Last time, I had to purge all but one Python installation from my machine to get it to make a consistent choice. But I just upgraded to VS 2019, and it smuggled in its own version.<div></div></div><div><br></div><div>So why are there two searches anyway? And why do they have different algorithms that lead to different results? (I'm not sure _how_ it ever found the Microsoft copy, since there's nothing in the process environment that points that way.)</div></div></blockquote><div><br></div><div>The reason there's two searches is because LLVM and LLDB have different requirements. LLVM just needs a python interpreter to run some scripts. LLDB on the other hand needs an interpreter and a matching Python library to link against. Before CMake 3.12, finding the interpreter and the libraries are two separate calls to find with no guarantees that they match. This lead to all kinds of issues, where you're linking against one version of Python and then trying to run the test suite with a totally different interpreter. There were other problems on Windows, which meant that we had our own hand-rolled implementation to find Python. </div><div><br></div><div>This was all fixed in CMake 3.12. With FindPython{2,3} you know you'll have a matching interpreter and library. It also fixed all the problems we had to work around for Windows. Unfortunately, LLVM's minimum CMake version is 3.4, so we can't use it yet. For LLDB on Windows we agreed that the benefits of using FindPython3 are worth bumping the minimum required CMake version (see lldb/CMakeLists.txt, line 2-4). Once LLVM moves to CMake 3.12 or later, all these problems should be fixed. We can then call FindPython3 once and rely on everything being consistent. </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 27, 2020 at 10:23 AM Jonas Devlieghere <<a href="mailto:jonas@devlieghere.com" target="_blank">jonas@devlieghere.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">Hey Adrian,<div><br></div><div>Config.h gets generated by expanding the corresponding CMake variables. If you look at LLDBConfig.cmake, you can see that LLDB_PYTHON_HOME is computed from PYTHON_EXECUTABLE. The problem appears that somehow CMake ignored your specified PYTHON_HOME and decided to pick a different Python. I'm not sure why though, because I use a similar CMake invocation on Windows. </div><div><br></div><div>> cmake ..\llvm-project\llvm -G Ninja -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_ENABLE_PROJECTS="llvm;clang;lldb;lld" -DLLVM_ENABLE_ASSERTIONS=OFF -DLLVM_ENABLE_ZLIB=FALSE -DLLDB_ENABLE_PYTHON=TRUE -DPYTHON_HOME="C:/Program Files/Python36/"<br></div><div><br></div><div>According to FindPython3 (<a href="https://cmake.org/cmake/help/v3.12/module/FindPython3.html" target="_blank">https://cmake.org/cmake/help/v3.12/module/FindPython3.html</a>), you can set Python3_ROOT_DIR as a hint. Can you give that a try? If that works we should populate that variable from PYTHON_HOME in FindPythonInterpAndLibs.cmake.</div><div><br></div><div>Cheers,</div><div>Jonas </div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 27, 2020 at 10:10 AM Adrian McCarthy via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Is there documentation on how lldb\include\lldb\host\config.h is generated? I'm again having the problem of the config trying to point to the wrong Python installation.<div><br></div><div>When I run cmake, I explicitly point PYTHON_HOME to C:\Python36 like this:</div><div><br></div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><div><font face="monospace" size="1">cmake -GNinja -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON -DCMAKE_BUILD_TYPE=Debug -DLLDB_TEST_DEBUG_TEST_CRASHES=1 -DPYTHON_HOME=C:\Python36 -DLLDB_TEST_COMPILER=D:\src\llvm\build\ninja\bin\clang.exe ..\..\llvm-project\llvm -DLLVM_ENABLE_ZLIB=OFF -DLLVM_ENABLE_PROJECTS="clang;lld;lldb"</font></div><div><font face="monospace" size="1"><br></font></div></blockquote><font size="1" face="arial, sans-serif">But the generated Config.h contains:</font><div><br></div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><div><font face="monospace" size="1">#define LLDB_PYTHON_HOME "C:/Program Files (x86)/Microsoft Visual Studio/Shared/Python37_64"</font></div></blockquote><div><font size="1" face="arial, sans-serif"><br></font></div><div><font size="1" face="arial, sans-serif">And the mismatch causes my build to fail because it goes looking for python37_d.dll, which is apparently not part of the Microsoft distribution.</font></div></div>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a></blockquote></div></blockquote></div></blockquote></div></div></blockquote><div><br></div><div>I've put up a patch to use PYTHON_HOME as the hint: <a href="https://reviews.llvm.org/D75275" target="_blank">https://reviews.llvm.org/D75275</a> </div></div></div></div>
</blockquote></div>
</blockquote></div>