<div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 16, 2020 at 2:42 PM Davidino Italiano via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org">lldb-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><br><div><br><blockquote type="cite"><div>On Apr 16, 2020, at 2:28 PM, Ted Woodward via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>> wrote:</div><br><div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><a href="http://lldb.llvm.org/resources/build.html" style="color:rgb(5,99,193);text-decoration:underline" target="_blank">http://lldb.llvm.org/resources/build.html</a><span> </span>Says we need swig 2 or later:<u></u><u></u></div><p style="margin-left:13.5pt;line-height:16.8pt;background-color:white"><span style="font-family:Georgia,serif;color:rgb(62,67,73)">If you want to run the test suite, you’ll need to build LLDB with Python scripting support.<u></u><u></u></span></p><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif;line-height:16.8pt;background-color:white"><span style="font-size:10pt;font-family:Symbol;color:rgb(62,67,73)"><span>·<span style="font-style:normal;font-variant-caps:normal;font-weight:normal;font-stretch:normal;font-size:7pt;line-height:normal;font-family:"Times New Roman"">        <span> </span></span></span></span><span style="font-family:Georgia,serif;color:rgb(62,67,73)"><a href="http://www.python.org/" style="color:rgb(5,99,193);text-decoration:underline" target="_blank"><span style="color:rgb(0,75,107)">Python</span></a><u></u><u></u></span></div><div style="margin:0in 0in 0.0001pt 0.5in;font-size:11pt;font-family:Calibri,sans-serif;line-height:16.8pt;background-color:white"><span style="font-size:10pt;font-family:Symbol;color:rgb(62,67,73)"><span>·<span style="font-style:normal;font-variant-caps:normal;font-weight:normal;font-stretch:normal;font-size:7pt;line-height:normal;font-family:"Times New Roman"">        <span> </span></span></span></span><span style="font-family:Georgia,serif;color:rgb(62,67,73)"><a href="http://swig.org/" style="color:rgb(5,99,193);text-decoration:underline" target="_blank"><span style="color:rgb(0,75,107)">SWIG</span></a> 2 or later.<u></u><u></u></span></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">I don’t think this is correct anymore.<u></u><u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">test/API/python_api/sbenvironment/TestSBEnvironment.py has this line:<u></u><u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">        env.Set("FOO", "bar", overwrite=True)<u></u><u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">lldb built with swig 2.0.11 fails this test with the error:<u></u><u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">    env.Set("FOO", "bar", overwrite=True)<u></u><u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">TypeError: Set() got an unexpected keyword argument 'overwrite'<u></u><u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">It works when lldb is built with swig 3.0.8.<u></u><u></u></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div></div></div></blockquote><br></div><div>Yes, we bumped the swig requirements.</div><div>Swig-2, among others, don’t support python 3 correctly.</div></div></blockquote><div><br></div><div><div style="color:rgb(0,0,0)">I think you're confusing SWIG 1.x and SWIG 2.x. We bumped the requirements to 2, because that's the first version that correctly supported Python 3. Personally I don't mind bumping the version again, but this seems more like a bug that we should be able to fix with SWIG 2. </div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><br></div><div>Feel free to submit a patch.</div><div><br></div><div>—</div><div>D</div></div>_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
</blockquote></div></div></div>