<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Starting in r372835 (Fix installing Python modules on systems using /usr/lib), the finish_swig and installation steps using multi-configuration generators (like Visual Studio or XCode) are broken.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The problem is the symlink and install steps look for liblldb and site-packages the wrong directories.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">For the symlink, I get this output:<o:p></o:p></p>
<p class="MsoNormal"> Making symlink from ..\..\..\bin\liblldb.dll to i:\obj\lib\site-packages\lldb\_lldb.pyd<o:p></o:p></p>
<p class="MsoNormal">…<o:p></o:p></p>
<p class="MsoNormal"> WindowsError: [Error 2] The system cannot find the file specified: '..\\..\\..\\bin\\liblldb.dll'<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Because the cwd is I:\obj\Lib\site-packages\lldb, not the correct I:\obj\Release\Lib\site-packages\lldb. liblldb.dll is in i:\obj\Release\bin, not i:\obj\bin. Also, the link itself should be in i:\obj\Release\lib, not i:\obj\lib.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The problem is the cmake code went from using LLVM_LIBRARY_OUTPUT_INTDIR to CMAKE_BINARY_DIR. CMAKE_BINARY_DIR is not complete for multi-configuration generators – you need to specify the configuration as well.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">To fix it, in lldb/CMakeLists.txt change<o:p></o:p></p>
<p class="MsoNormal"> if(LLDB_BUILD_FRAMEWORK)<o:p></o:p></p>
<p class="MsoNormal"> set(lldb_python_build_path "${liblldb_build_dir}/LLDB.framework/Resources/Python/lldb")<o:p></o:p></p>
<p class="MsoNormal"> else()<o:p></o:p></p>
<p class="MsoNormal"> set(lldb_python_build_path "${CMAKE_BINARY_DIR}/${LLDB_PYTHON_RELATIVE_PATH}/lldb")<o:p></o:p></p>
<p class="MsoNormal"> endif()<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">to:<o:p></o:p></p>
<p class="MsoNormal"> if(LLDB_BUILD_FRAMEWORK)<o:p></o:p></p>
<p class="MsoNormal"> set(lldb_python_build_path "${liblldb_build_dir}/LLDB.framework/Resources/Python/lldb")<o:p></o:p></p>
<p class="MsoNormal"> else()<o:p></o:p></p>
<p class="MsoNormal"> if(CMAKE_CFG_INTDIR)<o:p></o:p></p>
<p class="MsoNormal"> # use CMAKE_BUILD_TYPE here because CMAKE_CFG_INTDIR is ${Configuration}<o:p></o:p></p>
<p class="MsoNormal"> # using Visual Studio, which won't work in cmake_install.cmake<o:p></o:p></p>
<p class="MsoNormal"> # because it is a VS variable, not a cmake variable<o:p></o:p></p>
<p class="MsoNormal"> install(DIRECTORY ${CMAKE_BINARY_DIR}/${CMAKE_BUILD_TYPE}/${LLDB_PYTHON_RELATIVE_PATH}/<o:p></o:p></p>
<p class="MsoNormal"> DESTINATION ${LLDB_PYTHON_RELATIVE_PATH}<o:p></o:p></p>
<p class="MsoNormal"> COMPONENT lldb-scripts)<o:p></o:p></p>
<p class="MsoNormal"> else()<o:p></o:p></p>
<p class="MsoNormal"> install(DIRECTORY ${CMAKE_BINARY_DIR}/${LLDB_PYTHON_RELATIVE_PATH}/<o:p></o:p></p>
<p class="MsoNormal"> DESTINATION ${LLDB_PYTHON_RELATIVE_PATH}<o:p></o:p></p>
<p class="MsoNormal"> COMPONENT lldb-scripts)<o:p></o:p></p>
<p class="MsoNormal"> endif()<o:p></o:p></p>
<p class="MsoNormal"> endif()<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">In the install step we have a similar failure. The install in lldb/CMakeLists.txt again uses CMAKE_BINARY_DIR. To fix it, change:<o:p></o:p></p>
<p class="MsoNormal"> install(DIRECTORY ${CMAKE_BINARY_DIR}/${LLDB_PYTHON_RELATIVE_PATH}/<o:p></o:p></p>
<p class="MsoNormal"> DESTINATION ${LLDB_PYTHON_RELATIVE_PATH}<o:p></o:p></p>
<p class="MsoNormal"> COMPONENT lldb-scripts)<o:p></o:p></p>
<p class="MsoNormal">to:<o:p></o:p></p>
<p class="MsoNormal"> if(CMAKE_CFG_INTDIR)<o:p></o:p></p>
<p class="MsoNormal"> install(DIRECTORY ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${LLDB_PYTHON_RELATIVE_PATH}/<o:p></o:p></p>
<p class="MsoNormal"> DESTINATION ${LLDB_PYTHON_RELATIVE_PATH}<o:p></o:p></p>
<p class="MsoNormal"> COMPONENT lldb-scripts)<o:p></o:p></p>
<p class="MsoNormal"> else()<o:p></o:p></p>
<p class="MsoNormal"> install(DIRECTORY ${CMAKE_BINARY_DIR}/${LLDB_PYTHON_RELATIVE_PATH}/<o:p></o:p></p>
<p class="MsoNormal"> DESTINATION ${LLDB_PYTHON_RELATIVE_PATH}<o:p></o:p></p>
<p class="MsoNormal"> COMPONENT lldb-scripts)<o:p></o:p></p>
<p class="MsoNormal"> endif()<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Michal, please try this and see if it still works for the issue you fixed in r372835.<o:p></o:p></p>
</div>
</body>
</html>