This would be great. All of these tests have always been disabled on Windows so converting them to lit tests would increase test coverage there as well<br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 30, 2019 at 6:00 PM Alex Langford via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org">lldb-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+1<br>
<br>
Thanks for bringing this up. I'd like to see this happen!<br>
<br>
- Alex<br>
<br>
On 1/30/19, 5:33 PM, "lldb-dev on behalf of Davide Italiano via lldb-dev" <<a href="mailto:lldb-dev-bounces@lists.llvm.org" target="_blank">lldb-dev-bounces@lists.llvm.org</a> on behalf of <a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>> wrote:<br>
<br>
As you probably know (I didn’t), lldb embeds its own version of<br>
`pexpect-2.4`, which doesn’t support python3.<br>
This is the (relatively short) list of tests relying on pyexpect:<br>
<br>
testcases/tools/lldb-mi/syntax/TestMiSyntax.py: import pexpect<br>
# 7 (EOF)<br>
testcases/tools/lldb-mi/lldbmi_testcase.py: import pexpect<br>
testcases/tools/lldb-mi/signal/TestMiSignal.py: import pexpect<br>
testcases/tools/lldb-mi/signal/TestMiSignal.py: import pexpect<br>
testcases/lldbtest.py: import pexpect<br>
testcases/driver/batch_mode/TestBatchMode.py: import pexpect<br>
testcases/driver/batch_mode/TestBatchMode.py: import pexpect<br>
testcases/driver/batch_mode/TestBatchMode.py: import pexpect<br>
testcases/driver/batch_mode/TestBatchMode.py: import pexpect<br>
testcases/lldbpexpect.py: import pexpect<br>
testcases/terminal/TestSTTYBeforeAndAfter.py: import pexpect<br>
testcases/darwin_log.py: import pexpect<br>
testcases/macosx/nslog/TestDarwinNSLogOutput.py: import pexpect<br>
testcases/benchmarks/stepping/TestSteppingSpeed.py: import pexpect<br>
testcases/benchmarks/frame_variable/TestFrameVariableResponse.py:<br>
import pexpect<br>
testcases/benchmarks/turnaround/TestCompileRunToBreakpointTurnaround.py:<br>
import pexpect<br>
testcases/benchmarks/turnaround/TestCompileRunToBreakpointTurnaround.py:<br>
import pexpect<br>
testcases/benchmarks/expression/TestExpressionCmd.py: import pexpect<br>
testcases/benchmarks/expression/TestRepeatedExprs.py: import pexpect<br>
testcases/benchmarks/expression/TestRepeatedExprs.py: import pexpect<br>
testcases/benchmarks/startup/TestStartupDelays.py: import pexpect<br>
testcases/functionalities/command_regex/TestCommandRegex.py:<br>
import pexpect<br>
testcases/functionalities/single-quote-in-filename-to-lldb/TestSingleQuoteInFilename.py:<br>
import pexpect<br>
testcases/functionalities/format/TestFormats.py: import pexpect<br>
<br>
(I count 14, but there might be something else).<br>
<br>
I audited all of them and from what I see they’re almost all testing the driver.<br>
I had a chat with my coworkers and we agreed it's reasonable to<br>
replace them with lit tests (as they're just running commands).<br>
This would allow us to get rid of an external dependency, which<br>
happened to be cause of trouble in the past.<br>
<br>
Are there any objections?<br>
<br>
Thanks,<br>
<br>
--<br>
Davide<br>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_lldb-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=plcBe-Lvb3GcVnji0z26DNJmyn6uNsBq7AW-IQ7KAQQ&m=oo0_7ONGQhEkwtwF6DG8I6sVC2lUR-vlmka8pm4v1k0&s=zp1B92i8MPZxGtbFYUADj5J4GqHwpC1-g_x3fIN1hq0&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_lldb-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=plcBe-Lvb3GcVnji0z26DNJmyn6uNsBq7AW-IQ7KAQQ&m=oo0_7ONGQhEkwtwF6DG8I6sVC2lUR-vlmka8pm4v1k0&s=zp1B92i8MPZxGtbFYUADj5J4GqHwpC1-g_x3fIN1hq0&e=</a><br>
<br>
<br>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
</blockquote></div>