<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Aug 14, 2018, at 6:07 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><br class=""></div><div class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Tue, Aug 14, 2018 at 5:56 PM Vedant Kumar <<a href="mailto:vsk@apple.com" class="">vsk@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space" class=""><br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Aug 14, 2018, at 5:34 PM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank" class="">zturner@google.com</a>> wrote:</div><br class="m_-2403131304781074189Apple-interchange-newline"><div class="">I’ve thought about this in the past but the conclusion I came to is that lldbinline tests are actually just filecheck tests in disguise. Why do we need both? I’d rather delete the lldbinline infrastructure entirely and make a new lit TestFormat that basically does what lldbinline already does </div></blockquote><div class=""><br class=""></div><div class="">An inline test does more than simply pattern-matching input. It builds a program, sets breakpoints, etc. I'd rather make this existing infrastructure easier to use than come up with something new.</div></div></div><div style="word-wrap:break-word;line-break:after-white-space" class=""><div class=""><div class=""><br class=""></div><div class="">vedant</div></div></div></blockquote><div dir="auto" class=""><br class=""></div><div dir="auto" class="">Right, but only one specific type of lit test depends on pattern matching, and those are the SHTest format tests. You can make an arbitrary test format, including one that builds programs, set breakpoints etc. the format and structure of an lldbinline test need not even change at all (except that I think we could eliminate the .py file). The lldbinline tests are about as close to a drop in fit for lit as we can get, the only thing that needs to happen is the code in lldbinline.py needs to move to something called InlineTestFormat.py and then be hooked into lit</div></div></div>
</div></blockquote></div><br class=""><div class="">Creating a new lit test format compatible with inline tests sounds like a nice follow-up step. The immediate problem I'm trying to address is that it's too cumbersome to write the tests I need without FileCheck-like checks in inline tests. I think introducing this functionality is a necessary prerequisite.</div><div class=""><br class=""></div><div class="">vedant</div><div class=""><br class=""></div></body></html>