<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On May 8, 2018, at 9:47 AM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">We don’t want the lowest levels of lldb to depend on clang. If this is useful we should move it from clang to llvm and use llvm::VersionTuple<br class=""></div></blockquote><div><br class=""></div>I agree, though this move will cause merging issues for many that have repositories that link against older llvm/clang. Doesn't affect me anymore, but Apple will be affected.</div><div><br class=""></div><div>Greg</div><div><br class=""></div><div><blockquote type="cite" class=""><div class=""><div class="gmail_quote"><div dir="ltr" class="">On Tue, May 8, 2018 at 9:26 AM Greg Clayton via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" class="">lldb-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">No issues from me.<br class="">
<br class="">
> On May 8, 2018, at 9:11 AM, Pavel Labath via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank" class="">lldb-dev@lists.llvm.org</a>> wrote:<br class="">
> <br class="">
> While moving Args around, I noticed that we have a bunch of<br class="">
> functions/classes that pass/store version numbers as a triplet of integers<br class="">
> (e.g. Platform::GetOSVersion). I got halfway into creating a wrapper class<br class="">
> for that when I noticed clang::VersionTuple, which is pretty much what I<br class="">
> wanted out of the box.<br class="">
> <br class="">
> Now there are small differences between this class, and what we have now:<br class="">
> it has an extra fourth "build" field, and it uses only 31 bits to represent<br class="">
> the values. None of these seem to matter (particularly as we are<br class="">
> converting our representation into this struct in some places) that much,<br class="">
> but before I go through the trouble of pulling this class into llvm<br class="">
> (although technically possible, it seems wrong to pull a clang dependency<br class="">
> at such a low level), I wanted to make sure we are able to use it.<br class="">
> <br class="">
> Do you see any reason why we could not replace our version triplets with<br class="">
> clang::VersionTuple ?<br class="">
> <br class="">
> cheers,<br class="">
> pl<br class="">
> _______________________________________________<br class="">
> lldb-dev mailing list<br class="">
> <a href="mailto:lldb-dev@lists.llvm.org" target="_blank" class="">lldb-dev@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br class="">
<br class="">
_______________________________________________<br class="">
lldb-dev mailing list<br class="">
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank" class="">lldb-dev@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>