<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">We should probably have a stack that we can push and pop these states?<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 28, 2017, at 10:59 AM, Leonard Mosescu via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" class="">lldb-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Thank you Jim! I'm at cppcon and I won't be able to work on it until Monday, but I can help with a code review if you're planning to take a stab at it.<div class=""><br class=""></div><div class="">I was hoping we can avoid dealing with reentrancy but I was wrong. For handling reentrancy I was briefly considering either maintaining a full blown command stack or perhaps just a nesting counter.</div><div class=""><br class=""></div><div class="">Also, with reentrancy, I think that interruption should affect the "outmost" command scope rather than just interrupting the current command, what do you think?</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Sep 27, 2017 at 6:46 PM, Jim Ingham via lldb-dev <span dir="ltr" class=""><<a href="mailto:lldb-dev@lists.llvm.org" target="_blank" class="">lldb-dev@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This actually asserts on any use "command source" is the one command that re-enters the command interpreter. It should be as simple as getting command source to rest the state flag before it goes to do the sourcing. I'll check that out tomorrow if nobody gets to it first.<br class="">
<br class="">
command source is one of a set of early commands that we got into lldb before we had hired the person who wrote the testsuite way way back in the day, and though we went and backfilled the tests at that point, apparently we missed command source. So we'll also have to add a test for that.<br class="">
<br class="">
I also filed:<br class="">
<br class="">
<a href="https://bugs.llvm.org/show_bug.cgi?id=34758" rel="noreferrer" target="_blank" class="">https://bugs.llvm.org/show_<wbr class="">bug.cgi?id=34758</a><br class="">
<br class="">
to cover the issue.<br class="">
<br class="">
Jim<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
lldb-dev mailing list<br class="">
<a href="mailto:lldb-dev@lists.llvm.org" class="">lldb-dev@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/lldb-dev</a><br class="">
</blockquote></div><br class=""></div>
_______________________________________________<br class="">lldb-dev mailing list<br class=""><a href="mailto:lldb-dev@lists.llvm.org" class="">lldb-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev<br class=""></div></blockquote></div><br class=""></div></body></html>