<div dir="ltr">Is this the right review?  <a href="https://reviews.llvm.org/D5922">https://reviews.llvm.org/D5922</a><div><br></div><div>Being that this was over 2 years ago, I suspect it was when we were supporting MSVC2012 and 2013.  Now that we're requiring MSVC2015, is it time to reconsider? I don't see any links to an MS Connect issue, so I don't know what the original bug was to know if it has been fixed.<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Feb 8, 2017 at 1:03 PM Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">It's a sad story. Read the comments and the review threads. It's hilarious.</div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"></div></div><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg">On Wed, Feb 8, 2017 at 1:00 PM, Zachary Turner via lldb-dev <span dir="ltr" class="gmail_msg"><<a href="mailto:lldb-dev@lists.llvm.org" class="gmail_msg" target="_blank">lldb-dev@lists.llvm.org</a>></span> wrote:<br class="gmail_msg"></div></div><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Why doesn't llvm::call_once() just use std::call_once on Windows?</div><div class="m_-5120040696815873400HOEnZb gmail_msg"><div class="m_-5120040696815873400h5 gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Wed, Feb 8, 2017 at 12:40 PM Hans Wennborg <<a href="mailto:hans@chromium.org" class="gmail_msg" target="_blank">hans@chromium.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The Win64 lldb build seems broken (at 294367).<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
I ran into this when trying to build the weekly snapshot<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
(<a href="http://www.llvm.org/builds/" rel="noreferrer" class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg" target="_blank">http://www.llvm.org/builds/</a>) which includes LLDB these days.<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
I suspect this might be related to Kamil's changes a few days ago. I<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
see Pavel committed something to fix Darwin afterwards.<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
Zach, do you know what's going on here? Do we have any buildbot<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
coverage for this?<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
   Creating library lib\liblldb.lib and object lib\liblldb.exp<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved external symbo<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
l "void __cdecl llvm::sys::_mm_mfence(void)" (?_mm_mfence@sys@llvm@@YAXXZ) refer<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
enced in function "void __cdecl llvm::call_once<class <lambda_e212a11f7f891e804e<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
713e15728a6adc> >(struct llvm::once_flag &,class <lambda_e212a11f7f891e804e713e1<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
5728a6adc> &&)" (??$call_once@V<lambda_e212a11f7f891e804e713e15728a6adc>@@$$V@ll<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
vm@@YAXAEAUonce_flag@0@$$QEAV<lambda_e212a11f7f891e804e713e15728a6adc>@@@Z)<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
LINK failed. with 1120<br class="m_-5120040696815873400m_-6239238600679238001gmail_msg gmail_msg">
</blockquote></div>
</div></div><br class="gmail_msg"></blockquote></div></div><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">_______________________________________________<br class="gmail_msg">
lldb-dev mailing list<br class="gmail_msg">
<a href="mailto:lldb-dev@lists.llvm.org" class="gmail_msg" target="_blank">lldb-dev@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br class="gmail_msg">
<br class="gmail_msg"></blockquote></div></div></blockquote></div></div></div>