<div dir="ltr"><div>It worked! <br><br>...but not before I set PYTHONPATH=C:\Program Files (x86)\LLVM\lib\site-packages\<wbr>lldb</div><div>Without that, it couldn't find the _lldb module, so we are not quite out of the woods yet.</div><div><br></div><div>When are you planning to make the next snapshot build? <br></div><div>Thanks!</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 9, 2017 at 3:48 PM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Vadim, it looks like your change was committed in r291291, and I've<br>
built a new snapshot today which includes it. Can you give it a try<br>
and see if everything works?<br>
<br>
Cheers,<br>
Hans<br>
<br>
On Thu, Jan 5, 2017 at 10:46 AM, Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:<br>
> I will commit it, in the meantime can you request commit access so that any<br>
> future patches you can commit?<br>
><br>
> On Wed, Jan 4, 2017 at 1:54 PM Vadim Chugunov <<a href="mailto:vadimcn@gmail.com">vadimcn@gmail.com</a>> wrote:<br>
>><br>
>> Thanks!<br>
>><br>
>> Would anyone be so kind to commit that?<br>
>><br>
>> On Wed, Jan 4, 2017 at 11:47 AM, Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>><br>
>> wrote:<br>
>>><br>
>>> Sorry, a combination of national holidays and extended vacations happened<br>
>>> and this fell off my radar. lgtm<br>
>>><br>
>>> On Wed, Jan 4, 2017 at 11:46 AM Vadim Chugunov <<a href="mailto:vadimcn@gmail.com">vadimcn@gmail.com</a>> wrote:<br>
>>>><br>
>>>> Zachary,<br>
>>>> Can you please take a look at that change?<br>
>>>> (<a href="https://reviews.llvm.org/D27476" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D27476</a>)<br>
>>>><br>
>>>> It'll be sad if another snapshot build gets published with broken lldb.<br>
>>>> :(<br>
>>>><br>
>>>><br>
>>>> On Tue, Dec 6, 2016 at 11:54 AM, Vadim Chugunov <<a href="mailto:vadimcn@gmail.com">vadimcn@gmail.com</a>><br>
>>>> wrote:<br>
>>>>><br>
>>>>> This seems to work: <a href="https://reviews.llvm.org/D27476" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D27476</a><br>
>>>>><br>
>>>>> On Mon, Dec 5, 2016 at 12:04 PM, Hans Wennborg <<a href="mailto:hans@chromium.org">hans@chromium.org</a>><br>
>>>>> wrote:<br>
>>>>>><br>
>>>>>> The only thing needed to build the installer should be having NSIS<br>
>>>>>> installed and building the "package" target generated by CMake. The<br>
>>>>>> other prerequisites are mostly for building the visual studio<br>
>>>>>> clang-format plugin.<br>
>>>>>><br>
>>>>>> Having said that, you don't even have to build the installer to see<br>
>>>>>> what goes in it. Just building the "install" target generated by CMake<br>
>>>>>> will install the same set of files.<br>
>>>>>><br>
>>>>>> I'm not sure how LLDB's cmake files are organized, but in the end<br>
>>>>>> what's required is invoking the install() command:<br>
>>>>>> <a href="https://cmake.org/cmake/help/v3.0/command/install.html" rel="noreferrer" target="_blank">https://cmake.org/cmake/help/<wbr>v3.0/command/install.html</a> In LLVM, this<br>
>>>>>> is done automatically by macros such as add_llvm_executale, etc.<br>
>>>>>><br>
>>>>>> On Mon, Dec 5, 2016 at 11:56 AM, Vadim Chugunov <<a href="mailto:vadimcn@gmail.com">vadimcn@gmail.com</a>><br>
>>>>>> wrote:<br>
>>>>>> > Hi Hans,<br>
>>>>>> ><br>
>>>>>> > I'd love to help, but I don't have half the tools that<br>
>>>>>> > build_llvm_package.bat requires installed on my machine. My setup<br>
>>>>>> > is to<br>
>>>>>> > build llvm with msbuild. Is it possible to build the installer<br>
>>>>>> > this way<br>
>>>>>> > too?<br>
>>>>>> ><br>
>>>>>> > Can you point me to the specific CMake source that determines what's<br>
>>>>>> > included in the package? At a glance, everything from<br>
>>>>>> > %LLVM%/lib/site-packages is missing.<br>
>>>>>> ><br>
>>>>>> > Vadim<br>
>>>>>> ><br>
>>>>>> > On Mon, Dec 5, 2016 at 10:41 AM, Hans Wennborg <<a href="mailto:hans@chromium.org">hans@chromium.org</a>><br>
>>>>>> > wrote:<br>
>>>>>> >><br>
>>>>>> >> Is anyone working on this?<br>
>>>>>> >><br>
>>>>>> >> I'm happy to include LLDB in the installer, but I'm really not the<br>
>>>>>> >> best person to be debugging it.<br>
>>>>>> >><br>
>>>>>> >> If more files need to be included in the install, that's configured<br>
>>>>>> >> in<br>
>>>>>> >> the CMake files (what's installed by the 'install' build target is<br>
>>>>>> >> also what ends up going into the installer). If it needs more build<br>
>>>>>> >> flags, patches to build_llvm_package.bat are welsome.<br>
>>>>>> ><br>
>>>>>> ><br>
>>>>>> ><br>
>>>>><br>
>>>>><br>
>>>><br>
>><br>
><br>
</blockquote></div><br></div>