<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Yes, writing that long path every time you run a test case was indeed the reason for that symlink. I stood it for a couple of weeks before it drove me round the bend! You want it to be a real path and not just have the test suite accept partial paths because it is really handy to use the shell’s filename completion. <div class=""><br class=""></div><div class="">Anyway, if there’s some compelling reason to remove the link, I’ll just remake it by hand in all my checkouts, not too much of a hardship. But it would be much better if we could remove that long path and move the test cases back into the test directory.<div class=""><br class=""></div><div class="">Jim</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 15, 2016, at 9:45 AM, Zachary Turner via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" class="">lldb-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">The reason they were put into the packages directory in the first place is because this forms a proper python package so that more code can be shared amongst test cases. I don't know why the symlink was ever created in the first place, sounds like that was probably put in place by someone who thought packages/python/lldbsuite/test was too much to type (hard to argue with, tbh). In any case, as long as you can maintain the package structure so that a testcase can write "from support import fs" then you can re-arrange stuff however you like.<div class=""><br class=""></div><div class="">I also think some people had expressed interest in writing bindings for other languages, but I haven't heard anything about that in some time, so until I see more effort on that front a concrete proposal, we don't need to worry about it.</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Dec 15, 2016 at 9:38 AM Chris Bieneman via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" class="">lldb-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">So, I want to delete the testcases symlink from the LLDB tree, and move the tests out of the packages directory into tests/testcases.<br class="gmail_msg">
<br class="gmail_msg">
A few reasons why I want to do this:<br class="gmail_msg">
(1) I can't imagine symlinks in SVN is something that works well on platforms that don't support symlinks (like Windows)<br class="gmail_msg">
(2) It trips up scripts and tools that try to operate on the files without calling realpath (while I know I could fix those, it is easier to just fix this)<br class="gmail_msg">
(3) It seems to me that it is completely unnecessary. In lldbsuite's __init__.py we already find the test cases by path from the lldb checkout root, so having them live in the python packages just seems odd.<br class="gmail_msg">
<br class="gmail_msg">
Thoughts?<br class="gmail_msg">
<br class="gmail_msg">
Is there a reason why they need to live in the packages directory that I'm unaware of?<br class="gmail_msg">
<br class="gmail_msg">
-Chris<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
lldb-dev mailing list<br class="gmail_msg">
<a href="mailto:lldb-dev@lists.llvm.org" class="gmail_msg" target="_blank">lldb-dev@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br class="gmail_msg">
</blockquote></div>
_______________________________________________<br class="">lldb-dev mailing list<br class=""><a href="mailto:lldb-dev@lists.llvm.org" class="">lldb-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev<br class=""></div></blockquote></div><br class=""></div></div></body></html>