<div dir="ltr">I think it goes without saying, but henceforth, no changes should be landed without first passing them through clang-format. Personally, I will be reverting any I see that don't conform. But I can't promise to catch all of them.</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Sep 6, 2016 at 2:17 PM Kate Stone via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org">lldb-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="gmail_msg">The storm of commit messages might be a subtle clue, but here it is officially: the reformatting is complete and I’ve verified that no tests regressed locally in our macOS suite. Please begin any validation process you’ve signed up for on another platform, and if changes are necessary go ahead and land them individually.<div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">From the commit message:</div><div class="gmail_msg"><br class="gmail_msg"></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px" class="gmail_msg"><div class="gmail_msg">*** This commit represents a complete reformatting of the LLDB source code</div><div class="gmail_msg">*** to conform to clang-format’s LLVM style. This kind of mass change has</div><div class="gmail_msg">*** two obvious implications:</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Firstly, merging this particular commit into a downstream fork may be a huge</div><div class="gmail_msg">effort. Alternatively, it may be worth merging all changes up to this commit,</div><div class="gmail_msg">performing the same reformatting operation locally, and then discarding the</div><div class="gmail_msg">merge for this particular commit. The commands used to accomplish this</div><div class="gmail_msg">reformatting were as follows (with current working directory as the root of</div><div class="gmail_msg">the repository):</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg"> find . \( -iname "*.c" -or -iname "*.cpp" -or -iname "*.h" -or -iname "*.mm" \) -exec clang-format -i {} +</div><div class="gmail_msg"> find . -iname "*.py" -exec autopep8 --in-place --aggressive --aggressive {} + ;</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">The version of clang-format used was 3.9.0, and autopep8 was 1.2.4.</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Secondly, “blame” style tools will generally point to this commit instead of</div><div class="gmail_msg">a meaningful prior commit. There are alternatives available that will attempt</div><div class="gmail_msg">to look through this change and find the appropriate prior commit. YMMV.</div></blockquote><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Thanks for your collective support and assistance in preparing for this change.</div><div class="gmail_msg"><br class="gmail_msg"><div class="gmail_msg"></div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg">
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="font-family:LucidaGrande;word-wrap:break-word" class="gmail_msg"><div style="word-wrap:break-word" class="gmail_msg"><font color="#424242" style="font-family:'Lucida Grande';font-size:x-small" class="gmail_msg">Kate Stone</font><span style="font-family:'Lucida Grande';font-size:x-small" class="gmail_msg"> </span><font color="#009193" style="font-family:'Lucida Grande';font-size:x-small" class="gmail_msg"><a href="mailto:k8stone@apple.com" class="gmail_msg" target="_blank">k8stone@apple.com</a></font></div><div style="font-family:Times;word-wrap:break-word" class="gmail_msg"><font face="Lucida Grande" size="1" class="gmail_msg"><font color="#009193" class="gmail_msg"></font> Xcode <font color="#424242" class="gmail_msg">Low Level Tools</font></font></div></div></div></div></div></div>
</div>
<br class="gmail_msg"></div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg">On Sep 6, 2016, at 10:24 AM, Kate Stone <<a href="mailto:k8stone@apple.com" class="gmail_msg" target="_blank">k8stone@apple.com</a>> wrote:</div><br class="m_-707426514682887560Apple-interchange-newline gmail_msg"><div class="gmail_msg"><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg">As has been discussed over the past few weeks the reformatting of the LLDB code base will take place shortly, followed by validation before committing these changes. Please suspend all commit activity. Any intervening commits <b class="gmail_msg">will be reverted</b> until the all-clear is given.</div><br class="gmail_msg"><div class="gmail_msg">
<div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word" class="gmail_msg"><div style="font-family:LucidaGrande;word-wrap:break-word" class="gmail_msg"><div style="word-wrap:break-word" class="gmail_msg"><font color="#424242" style="font-family:'Lucida Grande';font-size:x-small" class="gmail_msg">Kate Stone</font><span style="font-family:'Lucida Grande';font-size:x-small" class="gmail_msg"> </span><font color="#009193" style="font-family:'Lucida Grande';font-size:x-small" class="gmail_msg"><a href="mailto:k8stone@apple.com" class="gmail_msg" target="_blank">k8stone@apple.com</a></font></div><div style="font-family:Times;word-wrap:break-word" class="gmail_msg"><font face="Lucida Grande" size="1" class="gmail_msg"><font color="#009193" class="gmail_msg"></font> Xcode <font color="#424242" class="gmail_msg">Low Level Tools</font></font></div></div></div></div></div></div>
</div>
<br class="gmail_msg"></div></div></blockquote></div><br class="gmail_msg"></div></div></div>_______________________________________________<br class="gmail_msg">
lldb-dev mailing list<br class="gmail_msg">
<a href="mailto:lldb-dev@lists.llvm.org" class="gmail_msg" target="_blank">lldb-dev@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br class="gmail_msg">
</blockquote></div>