<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 11, 2016, at 11:36 AM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I was thinking the same thing too. I figured this was just for the interim.<div class=""><br class=""></div><div class="">Chris, did you mean to update the global LLVM style conventions?</div></div></div></blockquote><div><br class=""></div><div>Yes, I meant that this should get updated:</div><div><a href="http://llvm.org/docs/CodingStandards.html#include-style" class="">http://llvm.org/docs/CodingStandards.html#include-style</a></div><div><br class=""></div><div>-Chris</div><br class=""><blockquote type="cite" class=""><div class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Aug 11, 2016 at 11:27 AM Jim Ingham <<a href="mailto:jingham@apple.com" class="">jingham@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Shouldn't this be made general and added to the llvm coding conventions? I was assuming that upon completion of this exercise, we would delete the lldb coding conventions doc.<br class="">
<br class="">
Jim<br class="">
<br class="">
> On Aug 11, 2016, at 11:20 AM, Zachary Turner via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank" class="">lldb-dev@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> On Wed, Aug 10, 2016 at 10:37 PM Chris Lattner <<a href="mailto:clattner@apple.com" target="_blank" class="">clattner@apple.com</a>> wrote:<br class="">
><br class="">
>> On Aug 9, 2016, at 3:01 PM, Zachary Turner via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank" class="">lldb-dev@lists.llvm.org</a>> wrote:<br class="">
>><br class="">
>> So perhaps it would be reasonable for us to standardize on something like this:<br class="">
>><br class="">
>> • Main Module Header<br class="">
>> • Local/Private Headers<br class="">
>> • lldb/...<br class="">
>> • llvm/...<br class="">
>> • System #includes<br class="">
><br class="">
> This makes sense to me, and matches what clang does as well. I think that this is clearly in the spirit of the llvm include order standards, and I think it would be great to make this explicit in the coding standard doc. Can you send in a patch to update it to make this explicit? I’ll review it.<br class="">
><br class="">
> -Chris<br class="">
><br class="">
> I actually just submitted the patch. (Sorry, itchy trigger finger or something). r278373. If you have any comments let me know and I'm happy to iterate on it.<br class="">
><br class="">
> _______________________________________________<br class="">
> lldb-dev mailing list<br class="">
> <a href="mailto:lldb-dev@lists.llvm.org" target="_blank" class="">lldb-dev@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>