<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 9, 2016, at 3:01 PM, Zachary Turner via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" class="">lldb-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">So perhaps it would be reasonable for us to standardize on something like this:</div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><ol class="inbox-inbox-inbox-inbox-arabic inbox-inbox-inbox-inbox-simple" id="inbox-inbox-inbox-inbox-local-private-headers" style="font-family: 'lucida grande', 'lucida sans unicode', geneva, verdana, sans-serif; font-size: 14px; line-height: 21px;"><li class="">Main Module Header</li><li class="">Local/Private Headers<br class=""></li><li class=""><code class="inbox-inbox-inbox-inbox-inbox-inbox-literal inbox-inbox-inbox-inbox-inbox-inbox-docutils" style="font-family: consolas, 'deja vu sans mono', 'bitstream vera sans mono', monospace; font-size: 0.95em;"><span class="inbox-inbox-inbox-inbox-inbox-inbox-pre">lldb/...</span></code></li><li class=""><code class="inbox-inbox-inbox-inbox-docutils inbox-inbox-inbox-inbox-literal" style="font-family: consolas, 'deja vu sans mono', 'bitstream vera sans mono', monospace; font-size: 0.95em;"><span class="inbox-inbox-inbox-inbox-pre">llvm/...</span></code></li><li class="">System<span class="inbox-inbox-inbox-inbox-Apple-converted-space"> </span><code class="inbox-inbox-inbox-inbox-docutils inbox-inbox-inbox-inbox-literal" style="font-family: consolas, 'deja vu sans mono', 'bitstream vera sans mono', monospace; font-size: 0.95em;"><span class="inbox-inbox-inbox-inbox-pre">#include</span></code>s</li></ol></div></div></blockquote><br class=""></div><div>This makes sense to me, and matches what clang does as well. I think that this is clearly in the spirit of the llvm include order standards, and I think it would be great to make this explicit in the coding standard doc. Can you send in a patch to update it to make this explicit? I’ll review it.</div><div><br class=""></div><div>-Chris</div></body></html>