<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>To be frank, I do not like that either. I could add the test the DWARF emission feature hit OCaml packages.<br><br>Anyway, here are the patches. I would be fine with just the code review if the absence of tests is a bother.<br>I ran check-lldb before and after applying the patches, and AFAIK I didn't introduce any regressions.<br><br>Elias<br><br><div><hr id="stopSpelling">From: tberghammer@google.com<br>Date: Thu, 7 Jul 2016 13:23:41 +0000<br>Subject: Re: [lldb-dev] Add support for OCaml native debugging<br>To: e.boutaleb@hotmail.fr; lldb-dev@lists.llvm.org<br><br><div dir="ltr">What type of binaries do you want to commit in?<div><br></div><div>Generally we don't like putting binaries to the repository because they are not human readable so it is hard to review/diff them and they will only run on a single platform and a single architecture while we support a lot of different configuration.<div><br></div><div>Tamas</div></div></div><br><div class="ecxgmail_quote"><div dir="ltr">On Wed, Jul 6, 2016 at 3:26 PM E BOUTALEB via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org">lldb-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="ecxgmail_quote" style="border-left:1px #ccc solid;padding-left:1ex;">
<div class="ecxm_-7451144546500176454hmmessage"><div dir="ltr">I would like to submit two patches for code review.<br>They introduce concrete support for OCaml native debugging, granted that you have access to the native compiler with DWARF emission support (see <font face="Calibri" size="3"><a href="https://github.com/ocaml/ocaml/pull/574" target="_blank">https://github.com/ocaml/ocaml/pull/574</a>)</font><br><br>This adds about 2000 lines of code. <br>The type system isn't particularly complex here, every value is considered as an unsigned integer, and interpretation of the value is left to an external debugging layer made in OCaml.<br>The language plugin handles function name demangling for breakpoints too.<br><br>No tests for now. Is it fine to commit binaries with the patchs?<br><br>Elias Boutaleb<br> </div></div>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
</blockquote></div></div> </div></body>
</html>