<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>I understand your concern.<br>I guess it could be possible to create a
conditional test exercised on a particular condition (like the presence
of the native compiler), and skipped otherwise.<br>Is it possible for
new files to trigger regressions? Most of the changes concern the
language plugins, AST context and DWARF parser.<br><br>Elias<br><br><div><hr id="stopSpelling">From: zturner@google.com<br>Date: Thu, 7 Jul 2016 16:05:06 +0000<br>Subject: Re: [lldb-dev] Add support for OCaml native debugging<br>To: tberghammer@google.com; e.boutaleb@hotmail.fr; lldb-dev@lists.llvm.org<br><br>I don't like the idea of not having tests. Promising tests and actually delivering on them are two entirely different things. And without them, we just end up with broken code and nobody to maintain it<br><div class="ecxgmail_quote"><div dir="ltr">On Thu, Jul 7, 2016 at 6:23 AM Tamas Berghammer via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org">lldb-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="ecxgmail_quote" style="border-left:1px #ccc solid;padding-left:1ex;"><div dir="ltr">What type of binaries do you want to commit in?<div><br></div><div>Generally we don't like putting binaries to the repository because they are not human readable so it is hard to review/diff them and they will only run on a single platform and a single architecture while we support a lot of different configuration.</div></div><div dir="ltr"><div><div><br></div><div>Tamas</div></div></div><br><div class="ecxgmail_quote"><div dir="ltr">On Wed, Jul 6, 2016 at 3:26 PM E BOUTALEB via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="ecxgmail_quote" style="border-left:1px #ccc solid;padding-left:1ex;">
<div class="ecxm_2378263064336205682m_-7451144546500176454hmmessage"><div dir="ltr">I would like to submit two patches for code review.<br>They introduce concrete support for OCaml native debugging, granted that you have access to the native compiler with DWARF emission support (see <font face="Calibri" size="3"><a href="https://github.com/ocaml/ocaml/pull/574" target="_blank">https://github.com/ocaml/ocaml/pull/574</a>)</font><br><br>This adds about 2000 lines of code. <br>The type system isn't particularly complex here, every value is considered as an unsigned integer, and interpretation of the value is left to an external debugging layer made in OCaml.<br>The language plugin handles function name demangling for breakpoints too.<br><br>No tests for now. Is it fine to commit binaries with the patchs?<br><br>Elias Boutaleb<br> </div></div>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
</blockquote></div>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
</blockquote></div></div> </div></body>
</html>