<div dir="ltr">Okay. I'm stuck fixing the OS X build, but if you have something else to check, feel free to send it over my way and I can run it on another machine.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 26, 2016 at 7:52 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Humm.. it's a unicode literal, not sure why it's complaining. I guess I'll have to crack open my linux machine and see what's going on tomorrow.</div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 26, 2016 at 6:12 PM Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'm still getting a lot of these:<div><br></div><div></div></div><div dir="ltr"><div><div><br></div><div>Traceback (most recent call last):</div></div></div><div dir="ltr"><div><div> File "test/dotest.py", line 7, in <module></div><div> lldbsuite.test.run_suite()</div><div> File "/Users/tfiala/src/lldb-tot/lldb/packages/Python/lldbsuite/test/dotest.py", line 1089, in run_suite</div><div> resultclass=test_result.LLDBTestResult).run(configuration.suite)</div><div> File "/Users/tfiala/src/lldb-tot/lldb/third_party/Python/module/unittest2/unittest2/runner.py", line 162, in run</div><div> test(result)</div><div> File "/Users/tfiala/src/lldb-tot/lldb/third_party/Python/module/unittest2/unittest2/suite.py", line 65, in __call__</div><div> return self.run(*args, **kwds)</div><div> File "/Users/tfiala/src/lldb-tot/lldb/third_party/Python/module/unittest2/unittest2/suite.py", line 85, in run</div><div> self._wrapped_run(result)</div><div> File "/Users/tfiala/src/lldb-tot/lldb/third_party/Python/module/unittest2/unittest2/suite.py", line 115, in _wrapped_run</div><div> test._wrapped_run(result, debug)</div><div> File "/Users/tfiala/src/lldb-tot/lldb/third_party/Python/module/unittest2/unittest2/suite.py", line 117, in _wrapped_run</div><div> test(result)</div><div> File "/Users/tfiala/src/lldb-tot/lldb/third_party/Python/module/unittest2/unittest2/case.py", line 433, in __call__</div><div> return self.run(*args, **kwds)</div><div> File "/Users/tfiala/src/lldb-tot/lldb/third_party/Python/module/unittest2/unittest2/case.py", line 369, in run</div><div> self.dumpSessionInfo()</div><div> File "/Users/tfiala/src/lldb-tot/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1810, in dumpSessionInfo</div><div> print(u"Session info generated @", datetime.datetime.now().ctime(), file=self.session)</div></div></div><div dir="ltr"><div><div>TypeError: must be unicode, not str</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 26, 2016 at 5:42 PM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Oh missed this. I'll give it a shot, hang on.</div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Tue, Jan 26, 2016 at 5:14 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Bump. Can I re-submit this?</div><div><div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 26, 2016 at 10:54 AM Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Can one of you guys try out this patch and see if it works? If so I'll commit it.<div><br></div><div>I don't know of a way to make this "elegant". i.e. a single syntax / paradigm that works in both versions without introducing any helper functions.</div></div><div dir="ltr"><div><br></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 26, 2016 at 12:26 AM Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">No worries, worst case scenario a sledgehammer solution is to change all the places where we write to the session file to convert to unicode first (which would be a trivial conversion, since everything is going to be ascii, which is already valid utf 8).<div><br></div><div>The reason a problem arose at all is because TestCxxWcharT.py tried to write actual unicode characters to the session file. I don't think there's any way to prevent that because the characters could appear in a backtrace, in a variable name, or in a test that is specifically testing unicode. So we can't just have the one place that needs to write unicode encode it as bytes because there's no one place. </div><div><br></div><div>I'll sleep on it and try to see if there's a better solution. Maybe we can just make a function called write_session_file() that takes either a string or a unicode, converts it to a unicode if it's not already one, and then writes.<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jan 25, 2016 at 9:45 PM Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Okay we're back to green here:<div><a href="http://lab.llvm.org:8080/green/job/lldb_build_test/16173/" target="_blank">http://lab.llvm.org:8080/green/job/lldb_build_test/16173/</a><br></div><div><br></div><div>Thanks, Enrico!</div><div><br></div><div>Zachary, I may let this rest until the morning. If you want to try something else, shoot me a patch and I'll gladly try it.</div><div><br></div><div>-Todd</div></div><div class="gmail_extra"></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 25, 2016 at 9:16 PM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It's in item 3 from Effective Python, by Brett Slatkin, which goes over having methods that always go to unicode or to byte streams taking either unicode or byte style strings, for both Python 2 and Python 3. Essentially you figure out what you want it to be in, and you write a couple helper routes to go in either the "to unicode" or the "to bytes" direction. It basically looks at the type of the string/bytes you give it, and makes sure it becomes what you need. It's going to assume an encoding like utf-8.</div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Mon, Jan 25, 2016 at 9:09 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'm also not sure why Linux isn't failing. Looking at the documentation for <a>io.write</a> object, i see this:<div><br></div><div><dl><dt style="color:rgb(0,0,0);font-family:sans-serif;font-size:16px;line-height:20.8px;text-align:justify"><code style="padding:0px 1px;font-size:0.95em;background-color:rgb(236,240,243)">write</code><span>(</span><em>s</em><span>)</span><a href="https://docs.python.org/2/library/io.html#io.TextIOBase.write" title="Permalink to this definition" style="color:rgb(198,15,15);text-decoration:none;font-size:0.8em;padding:0px 4px" target="_blank"></a></dt><dd style="margin-top:3px;margin-bottom:10px;margin-left:30px;text-align:justify;line-height:20.8px;color:rgb(0,0,0);font-family:sans-serif;font-size:16px"><p style="margin-top:0px;line-height:20.8px">Write the <a href="https://docs.python.org/2/library/functions.html#unicode" title="unicode" style="color:rgb(53,95,124);text-decoration:none" target="_blank"><code style="padding:0px 1px;font-size:0.95em;background-color:rgb(236,240,243)"><span>unicode</span></code></a> string <em>s</em> to the stream and return the number of characters written.</p></dd></dl></div><div dir="ltr"><span style="line-height:19.5px">So clearly it does have to be a unicode object, and saying print(self.getvalue(), file=self.session) is clearly NOT printing a unicode string to the file.</span></div><div dir="ltr"><br></div><div>What's the pattern you're referring to? You can't convert a string to a unicode without specifying an encoding, and it seems annoying to have to do that on every single call to print.</div><div><div><div dir="ltr"><span style="font-size:13px;line-height:19.5px"><br></span></div><div dir="ltr">On Mon, Jan 25, 2016 at 8:54 PM Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">sorry, yea I stuck around for a while after that patch waiting for emails, but nothing came through. Please revert in the meantime, I'll work on a fix tomorrow.</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jan 25, 2016 at 8:52 PM Todd Fiala via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I think I see what happened w/r/t why no emails when out when the build went heavy red. (Well they went out internally, but not externally). When I made the change on Friday to improve the workflow for the Green Dragon OS X builder and test output, I switched email over to the builder step, which doesn't know anything about who made which changes. So it didn't know who to put on the blame list for the broken build. Drats, I'll have to figure that out.<div><br></div><div>I'd really prefer to have all those stages happening in one build step to keep it clear what's going on.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 25, 2016 at 8:25 PM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Well our whole test suite just stopped running, so yes.</div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Mon, Jan 25, 2016 at 6:58 PM, Enrico Granata <span dir="ltr"><<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span><blockquote type="cite"><div>On Jan 25, 2016, at 6:48 PM, Todd Fiala via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>> wrote:</div><br><div><div dir="ltr">Not sure exactly what it is, but all the tests are failing due to some bad assumptions of unicode vs. str on Python 2 vs. 3 if I had to guess.<div><br></div></div></div></blockquote><div><br></div></span><div>Author: zturner<br>Date: Mon Jan 25 18:59:42 2016<br>New Revision: 258759<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=258759&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=258759&view=rev</a><br>Log:<br>Write the session log file in UTF-8.<br><br>Previously we were writing in the default encoding, which depends<br>on the operating system and is not guaranteed to be unicode aware.<br>On Python 3, this would lead to a situation where writing unicode<br>text to the log file generates an exception. The fix here is to<br>write session logs using the proper encoding, which incidentally<br>fixes another test, so xfail is removed from that.<br></div><div><br></div><div>sounds like a likely culprit from what you’re saying</div><span><br><blockquote type="cite"><div><div dir="ltr"><div>I am not going to be able to look at details on that, but here's a link to the log on the OS X builder:</div><div><br></div></div></div></blockquote><div><br></div></span><div>Do you want me to revert?</div><br><blockquote type="cite"><div><span><div dir="ltr"><div><a href="http://lab.llvm.org:8080/green/job/lldb_build_test/16166/console" target="_blank">http://lab.llvm.org:8080/green/job/lldb_build_test/16166/console</a><br clear="all"><div><br></div>-- <br><div><div dir="ltr">-Todd</div></div>
</div></div></span>
_______________________________________________<br>lldb-dev mailing list<br><a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br></div></blockquote></div><br><div>
<div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br>Thanks,</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><i>- Enrico</i><br>📩 egranata@<font color="#ff2600"></font>.com ☎️ 27683</div>
</div>
<br></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr">-Todd</div></div>
</div>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
</blockquote></div></blockquote></div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div></div><div class="gmail_extra">-- <br><div><div dir="ltr">-Todd</div></div>
</div></blockquote></div></blockquote></div></div></blockquote></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div></div><div class="gmail_extra">-- <br><div><div dir="ltr">-Todd</div></div>
</div></blockquote></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">-Todd</div></div>
</div>