<div dir="ltr">Oh no worries, I borked the builder email on our currently cumbersome multi-step process.<div><br></div><div>They're failing with a permutation of this:</div><div><br></div><div><pre class="" style="white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">Traceback (most recent call last):
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2224, in dsym_test_method
return attrvalue(self)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 561, in wrapper
return func(self, *args, **kwargs)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py", line 31, in test_inferior_abort_received_debugserver
self.init_debugserver_test()
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py", line 199, in init_debugserver_test
(self.named_pipe_path, self.named_pipe, self.named_pipe_fd) = self.create_named_pipe()
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py", line 125, in create_named_pipe
self.addTearDownHook(shutdown_named_pipe)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1589, in addTearDownHook
print("Adding tearDown hook:", getsource_if_available(hook), file=sbuf)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 265, in __exit__
print(self.getvalue(), file=self.session)
TypeError: must be unicode, not str
Config=x86_64-/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
Traceback (most recent call last):
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/test/dotest.py", line 7, in <module>
lldbsuite.test.run_suite()
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/dotest.py", line 1089, in run_suite
resultclass=test_result.LLDBTestResult).run(configuration.suite)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/third_party/Python/module/unittest2/unittest2/runner.py", line 162, in run
test(result)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/third_party/Python/module/unittest2/unittest2/suite.py", line 65, in __call__
return self.run(*args, **kwds)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/third_party/Python/module/unittest2/unittest2/suite.py", line 85, in run
self._wrapped_run(result)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/third_party/Python/module/unittest2/unittest2/suite.py", line 115, in _wrapped_run
test._wrapped_run(result, debug)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/third_party/Python/module/unittest2/unittest2/suite.py", line 117, in _wrapped_run
test(result)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/third_party/Python/module/unittest2/unittest2/case.py", line 433, in __call__
return self.run(*args, **kwds)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/third_party/Python/module/unittest2/unittest2/case.py", line 361, in run
success = self.runMethod(testMethod, result)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/third_party/Python/module/unittest2/unittest2/case.py", line 413, in runMethod
result.addError(self, sys.exc_info())
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/test_result.py", line 148, in addError
method()
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1666, in markError
print("ERROR", file=sbuf)
File "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 265, in __exit__
print(self.getvalue(), file=self.session)
TypeError: must be unicode, not str</pre><pre class="" style="white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><br></pre><pre class="" style="white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><br></pre><pre class="" style="white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">There's a pattern for using a call that guarantees contents are converted to either (say) Unicode or Bytes, where the right way to do it depends on Python 2 or Python 3. I see that this isn't causing a problem on the Linux builder, which is a bit puzzling unless they are using Python 3. (Or something else is going on that isn't obvious).</pre><pre class="" style="white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><br></pre><pre class="" style="white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">I think I may leave it as is and try to fix it. If I can't figure it out quickly-ish tonight, I will revert and we can figure out the right fix tomorrow. (i.e. I'm not going to revert it right away if I can fix it quickly).</pre><pre class="" style="white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><br></pre><pre class="" style="white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">-Todd</pre></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 25, 2016 at 8:54 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">sorry, yea I stuck around for a while after that patch waiting for emails, but nothing came through. Please revert in the meantime, I'll work on a fix tomorrow.</div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Mon, Jan 25, 2016 at 8:52 PM Todd Fiala via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I think I see what happened w/r/t why no emails when out when the build went heavy red. (Well they went out internally, but not externally). When I made the change on Friday to improve the workflow for the Green Dragon OS X builder and test output, I switched email over to the builder step, which doesn't know anything about who made which changes. So it didn't know who to put on the blame list for the broken build. Drats, I'll have to figure that out.<div><br></div><div>I'd really prefer to have all those stages happening in one build step to keep it clear what's going on.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 25, 2016 at 8:25 PM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Well our whole test suite just stopped running, so yes.</div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Mon, Jan 25, 2016 at 6:58 PM, Enrico Granata <span dir="ltr"><<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span><blockquote type="cite"><div>On Jan 25, 2016, at 6:48 PM, Todd Fiala via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>> wrote:</div><br><div><div dir="ltr">Not sure exactly what it is, but all the tests are failing due to some bad assumptions of unicode vs. str on Python 2 vs. 3 if I had to guess.<div><br></div></div></div></blockquote><div><br></div></span><div>Author: zturner<br>Date: Mon Jan 25 18:59:42 2016<br>New Revision: 258759<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=258759&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=258759&view=rev</a><br>Log:<br>Write the session log file in UTF-8.<br><br>Previously we were writing in the default encoding, which depends<br>on the operating system and is not guaranteed to be unicode aware.<br>On Python 3, this would lead to a situation where writing unicode<br>text to the log file generates an exception. The fix here is to<br>write session logs using the proper encoding, which incidentally<br>fixes another test, so xfail is removed from that.<br></div><div><br></div><div>sounds like a likely culprit from what you’re saying</div><span><br><blockquote type="cite"><div><div dir="ltr"><div>I am not going to be able to look at details on that, but here's a link to the log on the OS X builder:</div><div><br></div></div></div></blockquote><div><br></div></span><div>Do you want me to revert?</div><br><blockquote type="cite"><div><span><div dir="ltr"><div><a href="http://lab.llvm.org:8080/green/job/lldb_build_test/16166/console" target="_blank">http://lab.llvm.org:8080/green/job/lldb_build_test/16166/console</a><br clear="all"><div><br></div>-- <br><div><div dir="ltr">-Todd</div></div>
</div></div></span>
_______________________________________________<br>lldb-dev mailing list<br><a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br></div></blockquote></div><br><div>
<div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br>Thanks,</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><i>- Enrico</i><br>📩 egranata@<font color="#ff2600"></font>.com ☎️ 27683</div>
</div>
<br></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr">-Todd</div></div>
</div>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
</blockquote></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">-Todd</div></div>
</div>