<div dir="ltr">Incidentally, once we can start requiring VS 2015 %z will be supported there. Not sure if MSVC is the only supported platform that currently doesn't support %z</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jan 4, 2016 at 11:24 AM Greg Clayton via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org">lldb-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Please do cast to 64 bit and user PRI*64 macros. %z isn't supported on all platforms and we need to get away from using it.<br>
<br>
> On Dec 28, 2015, at 10:32 AM, William Dillon via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>> wrote:<br>
><br>
> Hi Todd,<br>
><br>
> The example I put in my last email is one of a few (maybe one more) instances where the existing code casts to 64-bit and uses PRIu64. When I’m dabbling in existing code I try to copy the conventions that are already in place, so that’s why I went this way. I’m happy to change it to %zu. I was just checking about that.<br>
><br>
> - Will<br>
><br>
>> On Dec 28, 2015, at 10:24 AM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br>
>><br>
>> Hi William,<br>
>><br>
>> It looks like just the PRIx64/PRIu64 bits are needed from a visual inspection. The source variables that are printed from already are 64-bit always, aren't they? If they're not but they should be, that seems like the real underlying problem rather than needing to cast.<br>
>><br>
>> What kind of warning are you seeing if you just replace the % format specifier?<br>
>><br>
>> Thanks!<br>
>><br>
>> -Todd<br>
>><br>
>> On Sun, Dec 27, 2015 at 12:32 PM, William Dillon via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>> wrote:<br>
>> > Message: 1<br>
>> > Date: Sat, 26 Dec 2015 21:15:53 +0100<br>
>> > From: Joerg Sonnenberger via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>><br>
>> > To: <a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
>> > Subject: Re: [lldb-dev] Patch for addressing format warnings on 32-bit<br>
>> > Message-ID: <<a href="mailto:20151226201553.GB14119@britannica.bec.de" target="_blank">20151226201553.GB14119@britannica.bec.de</a>><br>
>> > Content-Type: text/plain; charset=utf-8<br>
>> ><br>
>> > On Fri, Dec 25, 2015 at 06:34:09PM -0800, William Dillon via lldb-dev wrote:<br>
>> >> There are a handful of -Wformat warnings on 32-bit platforms.<br>
>> >> I addressed all those that I’ve seen while working on Swift.<br>
>> >> Let me know if the git diff format is inappropriate for this.<br>
>> ><br>
>> > Don't cast size_t to uint64_t, format it with %zu directly.<br>
>> ><br>
>> > Joerg<br>
>> ><br>
>><br>
>> I can go ahead and do that, but I wonder whether there should be two different ways of handling this, even on the same line. For example:<br>
>><br>
>> - error.SetErrorStringWithFormat ("SoftwareBreakpointr::%s addr=0x%" PRIx64 ": tried to read %lu bytes but only read %" PRIu64, __FUNCTION__, m_addr, m_opcode_size, (uint64_t)bytes_read);<br>
>> + error.SetErrorStringWithFormat ("SoftwareBreakpointr::%s addr=0x%" PRIx64 ": tried to read %" PRIu64 " bytes but only read %" PRIu64, __FUNCTION__, m_addr, (uint64_t)m_opcode_size, (uint64_t)bytes_read);<br>
>><br>
>> - Will<br>
>> _______________________________________________<br>
>> lldb-dev mailing list<br>
>> <a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
>><br>
>><br>
>><br>
>> --<br>
>> -Todd<br>
><br>
> _______________________________________________<br>
> lldb-dev mailing list<br>
> <a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
<br>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
</blockquote></div>