<div dir="ltr">I'm fine with the idea.<div><br></div><div>FWIW the test events model will likely shift a bit, as it is currently a single sink, whereas I am likely to turn it into a test event filter chain shortly here. Formatters still make sense as they'll be the things at the end of the chain.</div><div><br></div><div>Minor detail, result_formatter.py should be results_formatter.py - they are ResultsFormatter instances (plural on Results since it transforms a series of results into coherent reported output). I'll rename that at some point in the near future, but if you shift a number of things around, you can do that.</div><div><br></div><div>I'm just about done with the multi-pass running. I expect to get an opt-in version of that running end of day today or worst case on Sunday. It would be awesome if you can hold off on any significant change like that until this little bit is done as I'm sure we'll collide, particularly since this hits dosep.py pretty significantly.</div><div><br></div><div>Thanks!</div><div><br></div><div>-Todd</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 11, 2015 at 1:33 AM, Pavel Labath via lldb-dev <span dir="ltr"><<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sounds like a reasonable thing to do. A couple of tiny remarks:<br>
- when you do the move, you might as well rename dotest into something<br>
else, just to avoid the "which dotest should I run" type of<br>
questions...<br>
- there is nothing that makes it obvious that "engine" is actually a<br>
"test running engine", as it sits in a sibling folder. OTOH,<br>
"test_engine" might be too verbose, and messes up tab completion, so<br>
that might not be a good idea either...<br>
<br>
pl<br>
<br>
<br>
On 10 December 2015 at 23:30, Zachary Turner via lldb-dev<br>
<div><div class="h5"><<a href="mailto:lldb-dev@lists.llvm.org">lldb-dev@lists.llvm.org</a>> wrote:<br>
> Currently our folder structure looks like this:<br>
><br>
> lldbsuite<br>
> |-- test<br>
> |-- dotest.py<br>
> |-- dosep.py<br>
> |-- lldbtest.py<br>
> |-- ...<br>
> |-- functionalities<br>
> |-- lang<br>
> |-- expression_command<br>
> |-- ...<br>
> etc<br>
><br>
> I've been thinking about organizing it like this instead:<br>
><br>
> lldbsuite<br>
> |-- test<br>
> |-- functionalities<br>
> |-- lang<br>
> |-- expression_command<br>
> |-- ...<br>
> |-- engine<br>
> |-- dotest.py<br>
> |-- dosep.py<br>
> |-- lldbtest.py<br>
> |-- ...<br>
><br>
> Anybody have any thoughts on this? Good idea or bad idea? The main reason<br>
> I want to do this is because as we start breaking up some of the code, it<br>
> makes sense to start having some subpackages under the `engine` folder (or<br>
> the `test` folder in our current world). For example, Todd and I have<br>
> discussed the idea of putting formatter related stuff under a `formatters`<br>
> subpackage. In the current world, there's no way to differentiate between<br>
> folders which contain tests and folders which contain test infrastructure,<br>
> so when we walk the directory tree looking for tests we end up walking a<br>
> bunch of directories that are used for test infrastructure code and not<br>
> actual tests. So I like the logical separation this provides -- having the<br>
> tests themselves all under a single subpackage.<br>
><br>
> Thoughts?<br>
><br>
</div></div>> _______________________________________________<br>
> lldb-dev mailing list<br>
> <a href="mailto:lldb-dev@lists.llvm.org">lldb-dev@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
><br>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org">lldb-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">-Todd</div></div>
</div>