<div dir="ltr">I'll dig in more when I get to it, but yeah I like the concept for sure.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 2, 2015 at 11:12 AM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ahh, that's a bummer if true. Because `contrib` is a nice way to group together all the things that all the things that have specific maintainers and so everyone else is allowed to break.</div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Wed, Dec 2, 2015 at 11:04 AM Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Dec 2, 2015 at 8:28 AM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Zachary,<br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Mon, Nov 30, 2015 at 9:23 AM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Has the xcode build been changed to use static bindings yet?</div></blockquote><div><br></div></span><div>It is only in our downstream branches. I stripped out support in <a href="http://llvm.org" target="_blank">llvm.org</a> lldb per our other threads.</div><span><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"> I got to thinking that maybe it would make sense to put them alongside the xcode workspace folders, just to emphasize that the static bindings were an artifact of how the xcode build works.</div></blockquote><div><br></div></span><div>We could do that. Internally we also use that for builds other than Xcode, so whatever solution I use (which is currently what I had proposed earlier but now have only in our branches) really needs to work for more than Xcode.</div><span><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"> This way we just say "Xcode build uses static bindings" and "CMake build needs an installed swig", and this is enforced at the directory level. <div><br></div></div></blockquote><div><br></div></span><div>That's a great compromise, I appreciate your thoughts on that. Since I need it for more than Xcode, right now the solution I have in our branch is working okay.</div><span><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div></div><div>In order to do this you'd have to probably make a new toplevel folder to house both the lldb.xcodeproj and lldb.xcworkspace folders, but I think that would be useful for other reasons as well. For example, I want to check in a visual studio python solution for the test suite at some point, and it would make sense if all of this additional stuff was in one place. So perhaps something like:<div><br></div><div>lldb</div><div>|__ contrib</div><div> |__ xcode</div><div> |__ LLDBWrapPython.cpp</div><div> |__ lldb.py</div><div> |__ lldb.xcodeproj</div><div> |__ lldb.xcworkspace<br></div><div> |__ msvc</div></div><div><br></div></div></blockquote><div><br></div></span><div>That structure may make sense. That could live in <a href="http://llvm.org" target="_blank">llvm.org</a>. Then for other OSes where I want similar behavior, I could just keep those parts in our branch. Ultimately I'd end up with multiple copies of the wrapper (for any OS we may build for internally), but I could symlink so that's not really any kind of issue.</div><div><br></div><div>This might work.</div><span><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div></div><div>I have been thinking about this idea of a contrib folder for a while anyway, but wanted to have more reasons to make use of it before I brought it up.</div><div><br></div><div>Good idea? Bad idea? Thoughts?</div></div>
</blockquote></span></div><br>I could see that layout making sense. If we did something like that, I think I'd separate moving the lldb.xcodeproj and lldb.xcworkspace from the creation of the contrib folder.</div></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>It looks like we may have some reasons why we need the Xcode workspace/project files at the top of the lldb source tree. I'm not sure we'll able to move those. But the rest of it looks like a reasonable way to go.</div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"> (i.e. I'd start with the wrapper part in there, and have the others move there at lower priority as a scheduling thing --- there's a bit of work to make the workspace/project change but should be totally doable).<br clear="all"><div><br></div><div>I think I like the idea since it reduces the number of merge issues I'd have to deal with.</div><span><font color="#888888"><div><br></div>-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div></div>
</blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr">-Todd</div></div>
</div></div></blockquote></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">-Todd</div></div>
</div>