<div dir="ltr">I don't remember to any discussion about it but I might just missed it (don't see it in the archive either).<div><br></div><div>From the efficiency perspective in most of the case evaluating the arguments for Printf should be very fast (printing local variable) and the few case where it isn't the case we can keep the condition (using "if (log.Enabled()) log.Printf(....)"). From readability perspective I think ignoring the "if (log)" in most of the case won't hurt and it will eliminate the possibility of missing a check what will cause a crash.<div><br></div><div>Tamas</div><div><br><div class="gmail_quote"><div dir="ltr">On Wed, Aug 12, 2015 at 1:37 PM Colin Riley via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
From an efficiency perspective, the arguments to Printf will still
need to be evaluated. Some of those arguments touch multiple areas
and will require significant effort to change into a new format,
which is essentially the exact same as we have now.<br>
<br>
Was there not a decision to stick with what we have now when this
came up a few weeks ago? Clean and easy to understand over verbose
any day of the week in my view.<br>
<br>
Colin</div><div bgcolor="#FFFFFF" text="#000000"><br>
<br>
<br>
<div>On 12/08/2015 11:52, Tamas Berghammer
via lldb-dev wrote:<br>
</div>
</div><div bgcolor="#FFFFFF" text="#000000"><blockquote type="cite">
<div dir="ltr">Hi All,
<div><br>
</div>
<div>At the moment logging in LLDB done in the following way:</div>
<div>Log* log = GetLogIfAllCategoriesSet(...);</div>
<div>if (log)</div>
<div> log->Printf(...);</div>
<div><br>
</div>
<div>This approach is clean and easy to understand but have the
disadvantage of being a bit verbose. What is the general
opinion about changing it to something like this?</div>
<div>Logger log = GetLogIfAllCategoriesSet(...);</div>
<div>log.Printf(...);</div>
<div><br>
</div>
<div>The idea would be to return a new type of object from
GetLogIfAllCategoriesSet with small size (size of a pointer)
what will check if the log category is enabled. From
efficiency perspective this change would have no effect and it
will simplify the writing of the logging statements.</div>
<div><br>
</div>
<div>Implementation details:</div>
<div>Logger would just contain a pointer to a Log object and
forward all call to that object if that one isn't null.
Additionally it will have a method to check for nullness of
the underlying log object if we want to do some calculation
only if the logging is enabled.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Tamas</div>
<div><br>
</div>
<div>P.S.: Other possible simplification in the logging system
would be to use LogIfAllCategoriesSet but it require the
specification of the log channel at each call and have a very
minor overhead because of checking for the enabled log
categories at each call.</div>
</div>
<br>
<fieldset></fieldset>
<br>
</blockquote></div><div bgcolor="#FFFFFF" text="#000000"><blockquote type="cite"><pre>_______________________________________________
lldb-dev mailing list
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a>
</pre>
</blockquote>
<br>
<pre cols="72">--
- Colin Riley
Senior Director,
Parallel/Graphics Debugger Systems
Codeplay Software Ltd
45 York Place, Edinburgh, EH1 3HP
Tel: 0131 466 0503
Fax: 0131 557 6600
Website: <a href="http://www.codeplay.com" target="_blank">http://www.codeplay.com</a>
Twitter: <a href="https://twitter.com/codeplaysoft" target="_blank">https://twitter.com/codeplaysoft</a>
This email and any attachments may contain confidential and /or privileged information and is for use by the addressee only. If you are not the intended recipient, please notify Codeplay Software Ltd immediately and delete the message from your computer. You may not copy or forward it,or use or disclose its contents to any other person. Any views or other information in this message which do not relate to our business are not authorized by Codeplay software Ltd, nor does this message form part of any contract unless so stated.
As internet communications are capable of data corruption Codeplay Software Ltd does not accept any responsibility for any changes made to this message after it was sent. Please note that Codeplay Software Ltd does not accept any liability or responsibility for viruses and it is your responsibility to scan any attachments.
Company registered in England and Wales, number: 04567874
Registered office: 81 Linkfield Street, Redhill RH1 6BY </pre>
</div>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
</blockquote></div></div></div></div>