<div dir="ltr">No one has even replied to the commit thread? that's where this kind of discussion should took place.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 12, 2015 at 6:27 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yea theres 886, 888, 889, and 890. I think all would have to be reverted. Is anyone on #llvm IRC that can help?<div class="HOEnZb"><div class="h5"><br><div class="gmail_quote">On Thu, Feb 12, 2015 at 6:25 PM Vince Harron <<a href="mailto:vharron@google.com" target="_blank">vharron@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">IIRC I used </p>
<p dir="ltr">llvm$ svn diff --revision 228885:228886 > ~/break.diff</p>
<p dir="ltr">llvm$ patch -p0 -R < ~/break.diff</p>
<p dir="ltr">Some hunks failed. Could've messed something up.</p>
<div class="gmail_quote">On Feb 12, 2015 6:20 PM, "Zachary Turner" <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hmm I checked the logs, that file hasn't been touched since that revision. What's unclean about the revert? Compile failure, or other test failure?<br><div class="gmail_quote">On Thu, Feb 12, 2015 at 6:13 PM Vince Harron <<a href="mailto:vharron@google.com" target="_blank">vharron@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">It doesn't revert cleanly</p>
<div class="gmail_quote">On Feb 12, 2015 6:11 PM, "Zachary Turner" <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We should revert this if it's definitely the culprit. Otherwise it's impossible for to detect another patch later which also causes a regression. It's easy to fix and resubmit later<br><div class="gmail_quote">On Thu, Feb 12, 2015 at 6:03 PM Vince Harron <<a href="mailto:vharron@google.com" target="_blank">vharron@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Rafael,<br><br><a href="http://lab.llvm.org:8011/builders/lldb-x86_64-debian-clang/builds/3326" target="_blank">http://lab.llvm.org:8011/builders/lldb-x86_64-debian-clang/builds/3326</a></div><div><br>Shows about 20 new test failures. I've narrowed it down to r228886<br><br><a href="http://llvm.org/viewvc/llvm-project?revision=228886&view=revision" target="_blank">http://llvm.org/viewvc/llvm-project?revision=228886&view=revision</a></div><div><br>Can you take a look and/or give me some idea what to look for?<br><br>Thanks,<br><br>Vince<br clear="all"><div><br></div>-- <br><div><div dir="ltr"><br><table cellspacing="0" cellpadding="0" style="font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Vince Harron |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Technical Lead Manager |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:vharron@google.com" target="_blank">vharron@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> <a href="tel:858-442-0868" value="+18584420868" target="_blank">858-442-0868</a></td></tr></tbody></table><br></div></div>
</div></div>
______________________________<u></u>_________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@cs.uiuc.edu" target="_blank">lldb-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/lldb-dev</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>
</blockquote></div>
</blockquote></div>
</div></div><br>_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@cs.uiuc.edu">lldb-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
<br></blockquote></div><br></div>