Looks ok to me, I'm not getting any errors.<br><br><div class="gmail_quote">On Fri Jan 16 2015 at 12:48:06 PM Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I will sync to ToT and fix up remaining windows issues.<br><br><div class="gmail_quote">On Fri Jan 16 2015 at 11:23:10 AM Vince Harron <<a href="mailto:vharron@google.com" target="_blank">vharron@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I did my best. I'm still unable to get Windows building.<div><br></div><div><a href="http://reviews.llvm.org/rL226301" style="font-size:13px" target="_blank">http://reviews.llvm.org/<u></u>rL226301</a><br></div><div><br></div></div><div class="gmail_extra"></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 16, 2015 at 9:47 AM, Vince Harron <span dir="ltr"><<a href="mailto:vharron@google.com" target="_blank">vharron@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Will fix ASAP</p><div><div>
<div class="gmail_quote">On Jan 16, 2015 6:59 AM, "Carlo Kok" <<a href="mailto:ck@remobjects.com" target="_blank">ck@remobjects.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
Vince Harron schreef op 1/16/2015 om 1:47 AM:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: vharron<br>
Date: Thu Jan 15 18:47:08 2015<br>
New Revision: 226234<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=226234&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>pr<u></u>oject?rev=226234&view=rev</a><br>
Log:<br>
Add Socket::Get[Remote/Local]<u></u>IpAdd<u></u>ress and unit tests<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D6917" target="_blank">http://reviews.llvm.org/D6917</a><br>
<br>
<br>
Added:<br>
lldb/trunk/gtest/unittest/<u></u>Hos<u></u>t/<br>
lldb/trunk/gtest/unittest/<u></u>Hos<u></u>t/Makefile<br>
lldb/trunk/gtest/unittest/<u></u>Hos<u></u>t/SocketAddressTest.cpp<br>
lldb/trunk/gtest/unittest/<u></u>Hos<u></u>t/SocketTest.cpp<br>
lldb/trunk/gtest/unittest/<u></u>Hos<u></u>t/SocketTestMock.cpp<br>
Modified:<br>
lldb/trunk/gtest/gtest.<u></u>xcodep<u></u>roj/project.pbxproj<br>
lldb/trunk/include/lldb/Host/<u></u><u></u>Socket.h<br>
lldb/trunk/include/lldb/Host/<u></u><u></u>SocketAddress.h<br>
lldb/trunk/source/Host/<u></u>common/<u></u>Socket.cpp<br>
lldb/trunk/source/Host/<u></u>common/<u></u>SocketAddress.cpp<br>
lldb/trunk/source/Plugins/<u></u>Pro<u></u>cess/MacOSX-Kernel/<u></u>ProcessKDP.<u></u>cpp<br>
</blockquote>
<br>
Looks like the open { after the case in:<br>
lldb/trunk/source/Host/common/<u></u><u></u>SocketAddress.cpp line 42 is not properly closed.<br>
<br>
-- <br>
Carlo Kok<br>
RemObjects Software<br>
</blockquote></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div><div class="gmail_extra">-- <br><div><div dir="ltr"><br><table cellspacing="0" cellpadding="0" style="font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Vince Harron |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Technical Lead Manager |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:vharron@google.com" target="_blank">vharron@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 858-442-0868</td></tr></tbody></table><br></div></div>
</div>
______________________________<u></u><u></u>_________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@cs.uiuc.edu" target="_blank">lldb-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailm<u></u>an/listinfo/lldb-dev</a><br>
</blockquote></div></blockquote></div>