<div dir="ltr">That is one option. Phabricator (<a href="http://reviews.llvm.org">http://reviews.llvm.org</a>) provides a convenient way to give people access to a grpahical diff, and include reviewers. The usual workflow is to create a diff in Phabricator, attach the patch to it, and set one of the subscribers to lldb-commits. This will automatically send email to the list.<div><br></div><div>Either is fine. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 1, 2014 at 7:02 AM, Andy Chien <span dir="ltr"><<a href="mailto:achien@blueshiftinc.com" target="_blank">achien@blueshiftinc.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I haven't really done this before. Now that I have a fix attached to the bug and verified what is the next step to get it upstream'd? Do I send the patch to lldb-commit?</div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Tue, Nov 25, 2014 at 12:41 PM, İsmail Dönmez <span dir="ltr"><<a href="mailto:ismail@donmez.ws" target="_blank">ismail@donmez.ws</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr">Reported as <a href="http://llvm.org/bugs/show_bug.cgi?id=21670" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=21670</a></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 25, 2014 at 7:53 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Can you file a bug at <a href="http://llvm.org/bugs/" target="_blank">http://llvm.org/bugs/</a> and Cc the author of the patch?<div><div><br><br><div class="gmail_quote">On Tue Nov 25 2014 at 9:49:43 AM İsmail Dönmez <<a href="mailto:ismail@donmez.ws" target="_blank">ismail@donmez.ws</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">AFAIK this is broken by r<span style="color:rgb(0,0,0);white-space:pre-wrap">221570 but sadly I don't have time to debug this.</span></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 25, 2014 at 7:12 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If you want to dig in and try to figure out why it's not working right, patches would be welcome.<div><div><br><br><div class="gmail_quote">On Tue Nov 25 2014 at 8:36:13 AM İsmail Dönmez <<a href="mailto:ismail@donmez.ws" target="_blank">ismail@donmez.ws</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div class="gmail_extra"><br><div class="gmail_quote"></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Nov 25, 2014 at 5:52 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looks to me like its not linking llvmsupport.a. Not sure why though. Can you try removing <br><br> -DBUILD_SHARED_LIBS=ON \<br> -DCMAKE_BUILD_TYPE=RelWithDebInfo \<div><div><br></div></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>This fixes the problem so looks like shared libs build is now broken.</div><div><br></div><div>Thanks.</div><div><br></div></div></div></div>
</blockquote></div>
</div></div></blockquote></div><br></div>
</blockquote></div>
</div></div></blockquote></div><br></div>
</div></div><br></div></div><span class="">_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@cs.uiuc.edu" target="_blank">lldb-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
<br></span></blockquote></div><br></div>
</blockquote></div><br></div>