<div dir="ltr">That's great news Kate! The other thing I would encourage is that, once guidelines are formalized and published, that we try to encourage everyone to get in the habit of running clang-format against their CLs before submitting. No point in having a coding standard if isn't followed. Daniel Jasper posted a script earlier in the thread that should make this easy. Perhaps some bumps will arise early on, but I think everyone is interested enough in having LLDB adopt clang-format that someone will be amenable to addressing any problems with clang-format that should arise.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Aug 20, 2014 at 10:43 AM, Kate Stone <span dir="ltr"><<a href="mailto:katherine_stone@apple.com" target="_blank">katherine_stone@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">I’ve been largely observing the thread, but just so not all the conversations happen internally, I should point out that I’m encouraging the team to go ahead and formalize coding standards so we can publish them to the community. I’ll strongly discourage ambiguity and guidelines that involve picking one style or another based on “what looks better.” We should make it clear where we expect conformance from submissions. Where our existing code base is inconsistent I strongly encourage hewing to established LLVM convention. We shouldn’t be arbitrarily different, and where we do differ we should be able to describe the specific rationale (as I’m sure Greg will gladly do when it comes to line length and naming conventions.)<div>
<br></div><div>I should probably also take a moment to introduce myself! I manage Apple’s LLDB efforts for Chris as well as the performance tools in Xcode. Since taking on the team I’ve been largely focused on our Swift efforts, but I do endeavor to keep up with what’s going on in the broader LLDB community.</div>
<div><br><div>
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word">
<div style="font-family:LucidaGrande;word-wrap:break-word"><font color="#424242" style="font-family:'Lucida Grande';font-size:x-small">Kate Stone</font><span style="font-family:'Lucida Grande';font-size:x-small"> </span><font color="#009193" style="font-family:'Lucida Grande';font-size:x-small"><a href="mailto:k8stone@apple.com" target="_blank">k8stone@apple.com</a></font></div>
<div style="font-family:Times;word-wrap:break-word"><font face="Lucida Grande" size="1"><font color="#009193"></font> Xcode <font color="#424242">Runtime Analysis Tools</font></font></div></div></div>
</div>
<br><div><blockquote type="cite"><div class=""><div>On Aug 19, 2014, at 10:16 AM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:</div><br></div><div><div><div class="h5">
<div dir="ltr">I brought this up in a thread on lldb-commits, but since it is of more general interest, I want to make a thread here as well.<div><br></div><div>Can we have clear direction on LLDB coding style? Ideally in the form of an update to <a href="http://lldb.llvm.org/" target="_blank">lldb.llvm.org</a>, but as that might require a little more effort, even some details in a response to this thread would be a help. Some things I've deduced from looking at the code, and other things I'm not so sure about, because of inconsistencies in the code or just no clear rule.</div>
<div><br></div><div>Indentation width: 4</div><div>Column limit: 140 (does this apply to comments too? Most function-declaration comments seem to wrap at 80)</div><div>Brace style: Allman</div><div> if (foo)</div><div>
{</div><div> // code here</div><div> }</div><div><br></div><div>Break after function return type: Always, only on declarations, only on definitions, only in headers, or never?</div><div><br></div><div>Space before function parentheses: When?</div>
<div><br></div><div>Indent case labels inside switch: A or B below?</div><div> switch (foo)</div><div> {</div><div> case A:</div><div> case B:</div><div> }</div><div><br></div><div>Indent braces inside of a case: A or B below?</div>
<div> switch (foo)</div><div> {</div><div> case A:</div><div> {</div><div> }</div><div> case B:</div><div> {</div><div> }</div><div> }</div><div><br></div><div>Any other rules I should be cognizant of?</div>
</div></div></div><div class="">
_______________________________________________<br>lldb-dev mailing list<br><a href="mailto:lldb-dev@cs.uiuc.edu" target="_blank">lldb-dev@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
</div></div></blockquote></div><br></div></div></blockquote></div><br></div>