<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">No, the changes would all be contained within lldb-mi as it just uses the LLDB public API.<div><br></div><div>—</div><div>Deepak</div><div><br><div><div>On 7 Aug 2014, at 18:45, Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Are all the changes localized to lldb-mi or do they trickle down into other areas of LLDB? If the latter, it would be nice if there were a way to split them out into separate changelists. Otherwise I suspect it will be a difficult merge, and likely to stomp some other stuff that has gone in since the commit activity has picked up recently.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Aug 7, 2014 at 10:30 AM, Deepak Panickal <span dir="ltr"><<a href="mailto:deepak@codeplay.com" target="_blank">deepak@codeplay.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Abid,<br>
<br>
I actually had a bunch of fixes and new features to upstream for lldb-mi, which I plan to do tomorrow.<br>
Could you please hold off committing this patch till then?<br>
<br>
Thanks,<br>
Deepak<div><div class="h5"><br>
<br>
On 07/08/2014 18:19, Abid, Hafiz wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Deepak,<br>
I was testing lldb-mi and I found a few issues with the break-insert command.<br>
<br>
1. The constructor of CMICmdArgValString used in this command did not provide an option to set m_bHandleDirPaths. So the parsing will fail on command like "26-break-insert --thread-group i1 -f /home/abidh/demos/main.c:22". I added another parameter to the constructor to solve this issue.<br>
<br>
2. The parameter -f does not take any argument. The code was thinking that it takes one which was causing an error.<br>
<br>
After these changes the break-insert command is working fine for me. Please let me know if you see any problem with these change. Otherwise I will apply them.<br>
<br>
Thanks,<br>
Abid<br>
</blockquote>
<br></div></div>
______________________________<u></u>_________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@cs.uiuc.edu" target="_blank">lldb-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/lldb-dev</a><br>
</blockquote></div><br></div>
</blockquote></div><br></div></body></html>