<div dir="ltr">> <span style="font-family:arial,sans-serif;font-size:12.7272720336914px"> Certainly, that seems more productive than asking people to stop committing.</span><div><span style="font-family:arial,sans-serif;font-size:12.7272720336914px"><br>
</span></div><div><span style="font-family:arial,sans-serif;font-size:12.7272720336914px">To be fair, it is *very* rare for a test break in the lldb code (without build bots being very effective at the moment) to be due to a change in llvm or clang.</span></div>
<div><span style="font-family:arial,sans-serif;font-size:12.7272720336914px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:12.7272720336914px">Obviously the build bots will help a lot here!</span></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 29, 2014 at 4:40 PM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">All good to hear.<div><br></div><div>Let me know when we have hardware and I will get them build bots a-running :-)</div>
<span class="HOEnZb"><font color="#888888"><div><br></div><div>-Todd</div></font></span></div><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">
On Tue, Jul 29, 2014 at 4:37 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote"><div>On Tue, Jul 29, 2014 at 4:32 PM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="overflow:hidden">I generally sync llvm/clang in the AM, locked, and work with that throughout the day. If I kept up with TOT on all, all day long, I'm pretty sure my work machine, big as it is, would be building all day long ;-)</div>
</blockquote><div><br></div></div><div>This certainly isn't true for LLVM, Clang, and LLD themselves. With cmake+ninja, it is not at all burdensome. I'm on the extreme end and will routinely update over 40 or 50 times a day. </div>
<div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="overflow:hidden"><div>
</div><div>The only time this has bitten me is when something LLDB depends on changes. Then I fix that or synch to the fix requirement that somebody else made.</div><div><br></div><div>Are you suggesting something different?</div>
</div></blockquote></div></div><br>I'm suggesting a) *always* sync in or order to "fix" so that it is easy to make cross-cutting changes without people wasting time inventing a compatible way of doing it, and b) to including syncing every repo as the first step of any "i have tests failing in a clean build?" sanity check. Certainly, that seems more productive than asking people to stop committing.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">In LLVM land we have build bots that make sure that if anyone breaks tests, the patch is reverted. Really, really fast. As a consequence, there is never a need to "stop committing". I think that's a much healthier plan especially with increasingly distributed contributors to LLDB.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Just my 2 cents though. As I said, I'm just lurking here. =D</div></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><div class="">-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>