<div dir="ltr">Disregard the above message, I got it done with no private define as discussed, so hopefully the patch I've uploaded is a better solution. If the methods and classes aren't intended to be used externally anyway, then there's no reason to even have them be part of the public interface to begin with, so I just made them all private.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 27, 2014 at 4:00 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hmm, I see. Complete Mac noobie here, is it possible to make these changes without Xcode? I looked at lldb.xcodeproj, and it's harder to read than a Visual Studio .vcxproj file, so I assume this isn't intended to be hand-edited.<div>
<br></div><div>Would it be sufficient to make my condition something like</div><div><br></div><div>#if defined(LLDB_API_INTERNAL) || defined(MAC_OSX)</div><div><br></div><div>submit it this way, and then let a mac person make the necessary changes to the Xcode build?</div>
</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 27, 2014 at 3:39 PM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>> <span style="font-family:arial,sans-serif;font-size:12.727272033691406px">Does Mac OSX use the cmake build?</span><div>
<span style="font-family:arial,sans-serif;font-size:12.727272033691406px"><br></span></div>
</div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">Not really. The Xcode lldb-tool build is the canonical MacOSX build. It builds with cmake but IIRC many (most?) of the tests fail with that build.</span></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Tue, May 27, 2014 at 2:59 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div>On Tue, May 27, 2014 at 2:56 PM, <<a href="mailto:jingham@apple.com" target="_blank">jingham@apple.com</a>> wrote:<br>
><br>
>> On May 27, 2014, at 2:49 PM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br>
</div><div>>> What I meant is that you change this (for example):<br>
>><br>
>> std::shared_ptr<ValueImpl> m_opaque_sp;<br>
>><br>
>> to this:<br>
>><br>
>> std::shared_ptr<ValueImpl>* m_opaque_sp;<br>
>><br>
>> And allocate in the constructor / copy constructor, delete in the<br>
>> destructor. Then you change every occurrence of m_opaque_sp-> to<br>
>> (*m_opaque_sp)-><br>
>><br>
><br>
> No, I don't think we should do that either. It just adds ugly boiler plate and the chance for error, and doesn't solve any actual problems.<br>
<br>
</div>Greg's suggestion will still generate the warnings (at least in MSVC),<br>
for the simple fact that the shared_ptr<> etc is declared as a<br>
stack-based class member. But if it's guaranteed that these methods<br>
aren't publicly accessible, then suppressing the warning is probably<br>
fine.<br>
<br>
I'm a Windows person, so I don't have the means to easily test this<br>
kind of change on Mac OSX. Does Mac OSX use the cmake build? If so,<br>
does this mean I only need to define LLDB_PRIVATE in the cmake file<br>
and can assume it will work on the Mac build? Or is there more<br>
involved?<br>
</div></div><div><div><div>_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@cs.uiuc.edu" target="_blank">lldb-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
</div></div></div></blockquote></div><span><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'">
<tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</font></span></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>