<div dir="ltr">Oh yeah I see it. Fixing it up.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, May 19, 2014 at 11:02 AM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class=""><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">> If you can revert the 32/64 but truncation warnings, please do.</span><div>
<span style="font-family:arial,sans-serif;font-size:12.727272033691406px"><br>
</span></div></div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">Ok - will do. If I can't figure out how to isolate and fix that, I'll just revert the whole thing. Thanks!</span></div>
</div>
<div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">On Mon, May 19, 2014 at 10:53 AM, Greg Clayton <span dir="ltr"><<a href="mailto:gclayton@apple.com" target="_blank">gclayton@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I believe this is something the project updating changed. If you can revert the 32/64 but truncation warnings, please do.<br>
<div><div><br>
> On May 19, 2014, at 10:30 AM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br>
><br>
> Hmm, I'mm seeing some warnings on the debugserver Xcode build that make it look like it may have just switched from a 32-bit build to a 64-bit build on the "lldb-tool | My Mac 64-bit" scheme.<br>
><br>
> For example, I'm seeing what I think are new warnings where system calls are returning 64 bits but they're placed in uint32_t and the like, and warning about losing integer precision.<br>
><br>
> I might have just been ignoring those before, though, and not realized it. Any thoughts, Greg? I will revert the change (or tweak if that's simple) based on whatever you need me to do here.<br>
><br>
> FWIW the debugserver gdb-remote protocol tests I have in TOT are all working fine.<br>
><br>
> Sample warnings follow (might be that -Wshorten-64-to-32 was added as part of the settings upgrade - so these may have always been there, just not noisy).<br>
><br>
> =====<br>
> In file included from /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:31:<br>
><br>
> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/DNBDataRef.h:61:47: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'const offset_t' (aka 'const unsigned int') [-Wshorten-64-to-32]<br>
><br>
> const offset_t size = GetSize();<br>
><br>
> ~~~~ ^~~~~~~~~<br>
><br>
> In file included from /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:34:<br>
><br>
> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/DNBTimer.h:89:29: warning: implicit conversion loses integer precision: 'const __darwin_time_t' (aka 'const long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]<br>
><br>
> sec = m_timeval.tv_sec;<br>
><br>
> ~ ~~~~~~~~~~^~~~~~<br>
><br>
> In file included from /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:35:<br>
><br>
> In file included from /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.h:21:<br>
><br>
> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachException.h:80:24: warning: implicit conversion loses integer precision: 'const value_type' (aka 'const long long') to 'int' [-Wshorten-64-to-32]<br>
><br>
> return exc_data[1];<br>
><br>
> ~~~~~~ ^~~~~~~~~~~<br>
><br>
> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1489:34: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]<br>
><br>
> bytes_read = ::read (stdout_fd, s, sizeof(s)-1);<br>
><br>
> ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
><br>
> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1513:34: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]<br>
><br>
> bytes_read = ::read (stderr_fd, s, sizeof(s)-1);<br>
><br>
> ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
><br>
> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1603:16: warning: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'useconds_t' (aka 'unsigned int') [-Wshorten-64-to-32]<br>
><br>
> usleep(proc->ProfileInterval());<br>
><br>
> ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~<br>
><br>
> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:2266:24: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'u_int' (aka 'unsigned int') [-Wshorten-64-to-32]<br>
><br>
> if (::sysctl (mib, len, &cpu, &cpu_len, 0, 0))<br>
><br>
> ~~ ^~~<br>
><br>
> /Users/tfiala/lldb/svn/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:42:20: warning: unused function 'CopyBundleIDForPath' [-Wunused-function]<br>
><br>
> static CFStringRef CopyBundleIDForPath (const char *app_bundle_path, DNBError &err_str);<br>
><br>
> ^<br>
><br>
><br>
><br>
><br>
><br>
><br>
> -Todd<br>
><br>
><br>
> On Mon, May 19, 2014 at 10:06 AM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br>
> Done:<br>
><br>
> tfiala-macbookpro:lldb tfiala$ svn commit<br>
> Sending lldb.xcodeproj/project.pbxproj<br>
> Sending lldb.xcodeproj/xcshareddata/xcschemes/LLDB.xcscheme<br>
> Sending lldb.xcodeproj/xcshareddata/xcschemes/Run Testsuite.xcscheme<br>
> Sending lldb.xcodeproj/xcshareddata/xcschemes/darwin-debug.xcscheme<br>
> Sending lldb.xcodeproj/xcshareddata/xcschemes/launcherRootXPCService.xcscheme<br>
> Sending lldb.xcodeproj/xcshareddata/xcschemes/launcherXPCService.xcscheme<br>
> Sending lldb.xcodeproj/xcshareddata/xcschemes/lldb-tool.xcscheme<br>
> Sending tools/debugserver/debugserver.xcodeproj/project.pbxproj<br>
> Sending tools/debugserver/debugserver.xcodeproj/xcshareddata/xcschemes/debugserver.xcscheme<br>
> Transmitting file data .........<br>
> Committed revision 209142.<br>
><br>
><br>
> On Mon, May 19, 2014 at 9:50 AM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br>
> Okay, will do, thanks!<br>
><br>
><br>
> On Mon, May 19, 2014 at 9:38 AM, Greg Clayton <<a href="mailto:gclayton@apple.com" target="_blank">gclayton@apple.com</a>> wrote:<br>
> Please, feel free to update the settings and check them in.<br>
><br>
> > On May 18, 2014, at 8:31 PM, Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br>
> ><br>
> > Hey guys,<br>
> ><br>
> > I consistently get a couple warnings on lldb.xcodeproj and debugserver.xcodeproj about "Update to recommended settings". Is there any reason why we couldn't run that upgrade and check it in? (Some kind of backwards compatibility we need to maintain?)\<br>
> ><br>
> > Thanks!<br>
> ><br>
> > --<br>
> > -Todd<br>
><br>
><br>
><br>
><br>
> --<br>
> -Todd<br>
><br>
><br>
><br>
> --<br>
> -Todd<br>
><br>
><br>
><br>
> --<br>
> -Todd<br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div dir="ltr">-Todd</div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">-Todd</div>
</div>