<div dir="ltr">I guess bonus points would be for adding clang --fixit for this one...</div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-03-26 20:40 GMT+01:00 Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'm not against it.<div><br></div><div>Locally I've occasionally done the static_cast<void*> (something_p) and that shuts up the gcc %p warning. (And in the process have found interesting things like enum cases being ignored, etc.).</div>
<div><br></div><div>One negative of all that IMHO is that it adds clutter, but if it helps us find real warnings, my vote would be to do it.</div></div><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">
On Wed, Mar 26, 2014 at 11:32 AM, Saleem Abdulrasool <span dir="ltr"><<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Mon, Mar 17, 2014 at 10:05 AM, Greg Clayton <span dir="ltr"><<a href="mailto:gclayton@apple.com" target="_blank">gclayton@apple.com</a>></span> wrote:<br>
</div><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yes, we might consider this is the GCC warning that Steve mentions below is able to be disabled for GCC builds.<br>
<br>
The one problem is the variety of warnings that are enabled by default on different systems. GCC enables different things by default, and so does clang. As the compilers change it will be hard for other people on other systems to keep up. Also, no changes should ever be reverted because of compiler warnings, people would need to fix them on the system on which they are failing due to the compiler differences...<br>
<br>
So currently, unless GCC can disable the lame "%p" warning when using anything but a "void *", this is a non-starter.</blockquote><div><br></div></div><div>I realise that this is probably an exercise in futility, but, if I were to spend the time to add the appropriate casts for the pointer conversions (which consequentially would quiet up some of the static analyzer warnings!), would there be any objections to that?</div>
<div><br></div><div>Having slowly cleaned up some of the warnings, it seems that there are actual minor things floating about that we were missing.</div><div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span><font color="#888888"><br>
Greg<br>
</font></span><div><div><br>
On Mar 15, 2014, at 9:42 AM, Steve Pucci <<a href="mailto:spucci@google.com" target="_blank">spucci@google.com</a>> wrote:<br>
<br>
> +1<br>
><br>
> On Linux/gcc, the great majority of warnings is for a warning about using %p in a printf with a void* argument, which IMHO is a bogus warning that only gcc emits, and AFAICT can't be disabled without disabling the other far-more-useful printf warnings. I wound up writing a script to filter these out from my build logs rather than try to fix them all.<br>
><br>
><br>
> On Sat, Mar 15, 2014 at 9:30 AM, Saleem Abdulrasool <<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>> wrote:<br>
> Hi,<br>
><br>
> As the LLDB build currently exists, there are a large number of warnings which clutter the build. This is even worse on Linux when building with gcc.<br>
><br>
> I was wondering if there would be any objection to forcing errors on warnings as they as they get cleaned up. This requires that the compiler support marking certain warnings a errors (i.e. -Werror=*). clang and gcc support many of these, and this would need to be conditionalised on compiler support to ensure that no one is prevented from continuing to build LLDB.<br>
><br>
> LLVM actually has buildbots that build with -Werror which helps prevent new errors from being integrated in clang and LLVM, unfortunately, the buildbot situation for LLDB is not as pretty. As such, I was wondering if it would be acceptable to push this down into the normal build.<br>
><br>
> --<br>
> Saleem Abdulrasool<br>
> compnerd (at) compnerd (dot) org<br>
><br>
> _______________________________________________<br>
> lldb-dev mailing list<br>
> <a href="mailto:lldb-dev@cs.uiuc.edu" target="_blank">lldb-dev@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
><br>
><br>
> _______________________________________________<br>
> lldb-dev mailing list<br>
> <a href="mailto:lldb-dev@cs.uiuc.edu" target="_blank">lldb-dev@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
<br>
</div></div></blockquote></div></div><div><br><br clear="all"><div><br></div>-- <br>Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org
</div></div></div>
<br>_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@cs.uiuc.edu" target="_blank">lldb-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br></div></div><span class="HOEnZb"><font color="#888888"><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'">
<tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</font></span></div>
<br>_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@cs.uiuc.edu">lldb-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
<br></blockquote></div><br></div>