<div dir="ltr">Verified locally and submitted.<div><br></div><div><div>Sending source/Symbol/ClangASTType.cpp</div><div>Transmitting file data .</div><div>Committed revision 198635.</div></div><div><br></div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Mon, Jan 6, 2014 at 11:46 AM, Greg Clayton <span dir="ltr"><<a href="mailto:gclayton@apple.com" target="_blank">gclayton@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Looks good.<br>
<div><div class="h5"><br>
On Jan 6, 2014, at 11:18 AM, Steve Pucci <<a href="mailto:spucci@google.com">spucci@google.com</a>> wrote:<br>
<br>
> A parameter to a clang method was removed from a call made by lldb (the value is determined from the context now). A fix is attached; can someone please review?<br>
><br>
> Thanks,<br>
> Steve<br>
><br>
> diff --git a/source/Symbol/ClangASTType.cpp b/source/Symbol/ClangASTType.cpp<br>
> index 0dfabcc..84a04d4 100644<br>
> --- a/source/Symbol/ClangASTType.cpp<br>
> +++ b/source/Symbol/ClangASTType.cpp<br>
> @@ -1134,7 +1134,7 @@ ClangASTType::GetTypeName () const<br>
> if (typedef_type)<br>
> {<br>
> const TypedefNameDecl *typedef_decl = typedef_type->getDecl();<br>
> - type_name = typedef_decl->getQualifiedNameAsString(printing_policy);<br>
> + type_name = typedef_decl->getQualifiedNameAsString();<br>
> }<br>
> else<br>
> {<br>
><br>
</div></div>> _______________________________________________<br>
> lldb-dev mailing list<br>
> <a href="mailto:lldb-dev@cs.uiuc.edu">lldb-dev@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
<br>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@cs.uiuc.edu">lldb-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a href="tel:+1-650-943-3180">650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>